fix(XML Node): Fix issue with not returning valid data #6565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6565 +/- ##
==========================================
- Coverage 28.83% 28.75% -0.08%
==========================================
Files 3041 3041
Lines 187533 187533
Branches 20750 20746 -4
==========================================
- Hits 54071 53929 -142
- Misses 132623 132765 +142
Partials 839 839
☔ View full report in Codecov by Sentry. |
Passing run #1354 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
netroy
pushed a commit
that referenced
this pull request
Jul 4, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 5, 2023
* master: fix(core): Remove typeorm patches, but still enforce transactions on every migration (#6594) feat(Strava Node): Add hide_from_home field in Activity Update (#5883) feat(Notion Node): Add option to update icon when updating a page (#5670) refactor: Setup node context API, and consolidate code between Webhook and Wait nodes (no-changelog) (#6464) fix(core): Fix migrations for MySQL/MariaDB (#6591) fix(editor): Show retry information in execution list only when it exists (#6587) fix(Strapi Node): Fix issue with pagination (#4991) refactor(Item Lists Node): Refactoring (#6575) feat: Add crowd.dev node and trigger node (#6082) ci: Add Github Action to enforce template to issues (#5295) fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572) fix(Brevo Node): Rename SendInBlue node to Brevo node (#6521) fix(XML Node): Fix issue with not returning valid data (#6565) feat(HTTP Request Node): New http request generic custom auth credential (#5798) fix(core): Fix credentials test (#6569) fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563) docs: Add irreversible change warning for [email protected] (no-changelog) (#6558) feat: Add various source control improvements (#6533) feat(Twitter Node): Node overhaul (#4788)
netroy
pushed a commit
that referenced
this pull request
Jul 5, 2023
This was referenced Jul 5, 2023
Merged
Closed
Merged
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 6, 2023
* master: (50 commits) fix(Google Drive Node): Fix regex in file RLC (#6607) feat(HTML Node): 'Convert to table operation (#6540) ci: e2e tests don't need to enable saving manual executions 🚀 Release 1.0.1 (#6606) fix(core): Make node execution order configurable, and backward-compatible (#6507) 🚀 Release 0.236.0 (#6602) fix: Fix migrations for postgres and mysql (no-changelog) (#6600) fix(core): Improve the performance of last 2 sqlite migrations (#6522) refactor: Switch cloud plan retrieval endpoint (no-changelog) (#6529) fix(Salesforce Node): Fix typo for adding a contact to a campaign (#6598) ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog) fix(editor): Restore expression completions (#6566) refactor: Remove basic auth env vars from docker compose stacks (#6570) fix(core): Fix migrations for MySQL/MariaDB (#6591) fix(editor): Show retry information in execution list only when it exists (#6587) fix(Strapi Node): Fix issue with pagination (#4991) fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572) fix(XML Node): Fix issue with not returning valid data (#6565) fix(core): Fix credentials test (#6569) fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563) ... # Conflicts: # packages/design-system/src/components/N8nCallout/Callout.vue # packages/editor-ui/src/App.vue # packages/editor-ui/src/plugins/i18n/locales/en.json # packages/editor-ui/src/stores/ui.store.ts
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/undefined-when-running-workflow-but-fine-when-running-node/27364?u=mutedjam
#6043