fix(core): Remove typeorm patches, but still enforce transactions on every migration #6594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on every migration This reverts #6519
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6594 +/- ##
==========================================
- Coverage 28.91% 28.84% -0.08%
==========================================
Files 3070 3070
Lines 188243 188259 +16
Branches 20876 20874 -2
==========================================
- Hits 54431 54298 -133
- Misses 132928 133076 +148
- Partials 884 885 +1
☔ View full report in Codecov by Sentry. |
n8n-assistant
bot
added
core
krynble
suggested changes
Jul 5, 2023
| export function logMigrationEnd(migrationName: string, disableLogging = inTest): void { | ||
| if (disableLogging) return; | ||
| function logMigrationEnd(migrationName: string): void { | ||
| if (inTest) return; |
There was a problem hiding this comment.
I think having the messages is always useful, especially if running when testing, don't you think?
There was a problem hiding this comment.
the logic hasn't really changed. we were never passing in a second argument, and disableLogging was always inTest.
krynble
approved these changes
Jul 5, 2023
2 flaky tests on run #1380 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| User Management > should delete user and their data |
Output
Screenshots
Video
|
|
20-workflow-executions.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Current Workflow Executions > should render executions tab correctly |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 5, 2023
* master: fix(core): Remove typeorm patches, but still enforce transactions on every migration (#6594) feat(Strava Node): Add hide_from_home field in Activity Update (#5883) feat(Notion Node): Add option to update icon when updating a page (#5670) refactor: Setup node context API, and consolidate code between Webhook and Wait nodes (no-changelog) (#6464) fix(core): Fix migrations for MySQL/MariaDB (#6591) fix(editor): Show retry information in execution list only when it exists (#6587) fix(Strapi Node): Fix issue with pagination (#4991) refactor(Item Lists Node): Refactoring (#6575) feat: Add crowd.dev node and trigger node (#6082) ci: Add Github Action to enforce template to issues (#5295) fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572) fix(Brevo Node): Rename SendInBlue node to Brevo node (#6521) fix(XML Node): Fix issue with not returning valid data (#6565) feat(HTTP Request Node): New http request generic custom auth credential (#5798) fix(core): Fix credentials test (#6569) fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563) docs: Add irreversible change warning for [email protected] (no-changelog) (#6558) feat: Add various source control improvements (#6533) feat(Twitter Node): Node overhaul (#4788)
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the typeorm patches from #6519
Extracted from #6522