Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Run the down migration correctly when transaction: false is set (no-changelog) #8432

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix(core): Run the down migration correctly when transaction: false is set (no-changelog) #8432

merged 1 commit into from
Jan 24, 2024

Conversation

netroy
Copy link
Member

@netroy netroy commented Jan 24, 2024

This bug was introduced 6 months ago in #6594

Review / Merge checklist

  • PR title and summary are descriptive

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jan 24, 2024
@cypress Cypress
Copy link

cypress bot commented Jan 24, 2024 •
edited
Loading

1 flaky test on run #3894 ↗︎

0 338 5 0 Flakiness 1

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: f438082442
Status: Passed Duration: 03:30 💡
Started: Jan 25, 2024 3:10 AM Ended: Jan 25, 2024 3:14 AM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8432 ↗︎

@github-actions GitHub Actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit f438082 into master Jan 24, 2024
32 checks passed
@netroy netroy deleted the fix-sqlite-db-revert branch January 24, 2024 18:07
@janober
Copy link
Member

janober commented Feb 2, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krynble krynble krynble approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @krynble