Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(HTTP Request Node): New http request generic custom auth credential #5798

Merged
merged 10 commits into from
Jun 29, 2023
Merged

feat(HTTP Request Node): New http request generic custom auth credential #5798

merged 10 commits into from
Jun 29, 2023

Conversation

maspio
Copy link
Contributor

@maspio maspio commented Mar 28, 2023

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Files matching packages/nodes-base/package.json:

  • Avoided adding dependencies for nodes if not absolutely necessary.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Mar 28, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.46 ⚠️

Comparison is base (e43924d) 28.72% compared to head (8d87222) 28.27%.

❗ Current head 8d87222 differs from pull request most recent head c9ae473. Consider uploading reports for the commit c9ae473 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5798      +/-   ##
==========================================
- Coverage   28.72%   28.27%   -0.46%     
==========================================
  Files        3000     2984      -16     
  Lines      186303   185063    -1240     
  Branches    20608    20338     -270     
==========================================
- Hits        53512    52318    -1194     
+ Misses     131980   131958      -22     
+ Partials      811      787      -24
Impacted Files Coverage Δ
...des-base/credentials/HttpCustomAuth.credentials.ts 0.00% <0.00%> (ø)
packages/nodes-base/nodes/GraphQL/GraphQL.node.ts 0.00% <0.00%> (ø)
...es-base/nodes/HttpRequest/V3/HttpRequestV3.node.ts 29.33% <0.00%> (-1.44%) ⬇️

... and 252 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 28, 2023
@maspio maspio marked this pull request as ready for review May 5, 2023 13:56
agobrech
agobrech approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@agobrech agobrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@agobrech agobrech self-requested a review May 12, 2023 11:27
agobrech
agobrech previously approved these changes May 12, 2023
View reviewed changes
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

1 similar comment
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@agobrech agobrech dismissed their stale review June 29, 2023 13:10

Tests stuck

@cypress
Copy link

cypress bot commented Jun 29, 2023

Passing run #1357 ↗︎

0 227 0 0 Flakiness 0

Details:

🌳 http-custom-auth-credential 🖥️ browsers:node18.12.0-chrome107 🤖 maspio 🗃️ ...
Project: n8n Commit: c9ae4739e6
Status: Passed Duration: 08:18 💡
Started: Jun 29, 2023 1:17 PM Ended: Jun 29, 2023 1:25 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@maspio maspio merged commit b17b458 into master Jun 29, 2023
@maspio maspio deleted the http-custom-auth-credential branch June 29, 2023 13:27
MiloradFilipovic added a commit that referenced this pull request Jul 5, 2023
@MiloradFilipovic
Merge branch 'master' into ADO-814-trial-banner
9937c46 
* master:
  fix(core): Remove typeorm patches, but still enforce transactions on every migration (#6594)
  feat(Strava Node): Add hide_from_home field in Activity Update (#5883)
  feat(Notion Node): Add option to update icon when updating a page (#5670)
  refactor: Setup node context API, and consolidate code between Webhook and Wait nodes (no-changelog) (#6464)
  fix(core): Fix migrations for MySQL/MariaDB (#6591)
  fix(editor): Show retry information in execution list only when it exists (#6587)
  fix(Strapi Node): Fix issue with pagination (#4991)
  refactor(Item Lists Node): Refactoring (#6575)
  feat: Add crowd.dev node and trigger node (#6082)
  ci: Add Github Action to enforce template to issues (#5295)
  fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572)
  fix(Brevo Node): Rename SendInBlue node to Brevo node (#6521)
  fix(XML Node): Fix issue with not returning valid data (#6565)
  feat(HTTP Request Node): New http request generic custom auth credential (#5798)
  fix(core): Fix credentials test (#6569)
  fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563)
  docs: Add irreversible change warning for [email protected] (no-changelog) (#6558)
  feat: Add various source control improvements (#6533)
  feat(Twitter Node): Node overhaul (#4788)
This was referenced Jul 5, 2023
Closed
Merged
@janober
Copy link
Member

janober commented Jul 5, 2023

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agobrech agobrech agobrech approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maspio @janober @agobrech