Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove basic auth env vars from docker compose stacks #6570

Merged
merged 3 commits into from
Jul 4, 2023

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jun 29, 2023

@ivov ivov added the v1 Issues related to the release of n8n version 1.x.x label Jun 29, 2023
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also remove this from the other .env files please?
image

@ivov ivov changed the title refactor: Remove basic auth env vars from MariaDB stack refactor: Remove basic auth env vars from docker compose stacks Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/1.0.0@f217e1f). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/1.0.0    #6570   +/-   ##
================================================
  Coverage                 ?   28.66%           
================================================
  Files                    ?     2998           
  Lines                    ?   186246           
  Branches                 ?    20600           
================================================
  Hits                     ?    53381           
  Misses                   ?   132056           
  Partials                 ?      809           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Jun 29, 2023
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Jun 29, 2023

1 failed tests on run #1365 ↗︎

1 129 0 0 Flakiness 0

Details:

🌳 n8n-6582-update-docker-compose-stacks-for-v1 🖥️ browsers:node18.12.0-chrome1...
Project: n8n Commit: 799444e248
Status: Failed Duration: 05:43 💡
Started: Jun 30, 2023 3:28 PM Ended: Jun 30, 2023 3:34 PM
Failed  2-credentials.cy.ts • 1 failed test

View Output Video

Test Artifacts
Credentials > should sort credentials Output Screenshots Video
Failed  24-ndv-paired-item.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  14-mapping.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  25-stickies.cy.ts • 0 failed tests

View Output Video

Test Artifacts
Failed  18-user-management.cy.ts • 0 failed tests

View Output Video

Test Artifacts

The first 5 failed specs are shown, see all 19 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Joffcom
Copy link
Member

Joffcom commented Jun 29, 2023

@ivov @netroy as we are planning to remove MySQL / MariaDB in the future why not remove the MariaDB example as well?

Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💟

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@netroy netroy merged commit 075fd02 into release/1.0.0 Jul 4, 2023
@netroy netroy deleted the n8n-6582-update-docker-compose-stacks-for-v1 branch July 4, 2023 19:15
MiloradFilipovic added a commit that referenced this pull request Jul 6, 2023
* master: (50 commits)
  fix(Google Drive Node): Fix regex in file RLC (#6607)
  feat(HTML Node): 'Convert to table operation (#6540)
  ci: e2e tests don't need to enable saving manual executions
  🚀 Release 1.0.1 (#6606)
  fix(core): Make node execution order configurable, and backward-compatible (#6507)
  🚀 Release 0.236.0 (#6602)
  fix: Fix migrations for postgres and mysql (no-changelog) (#6600)
  fix(core): Improve the performance of last 2 sqlite migrations (#6522)
  refactor: Switch cloud plan retrieval endpoint (no-changelog) (#6529)
  fix(Salesforce Node): Fix typo for adding a contact to a campaign (#6598)
  ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog)
  fix(editor): Restore expression completions (#6566)
  refactor: Remove basic auth env vars from docker compose stacks (#6570)
  fix(core): Fix migrations for MySQL/MariaDB (#6591)
  fix(editor): Show retry information in execution list only when it exists (#6587)
  fix(Strapi Node): Fix issue with pagination (#4991)
  fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572)
  fix(XML Node): Fix issue with not returning valid data (#6565)
  fix(core): Fix credentials test (#6569)
  fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563)
  ...

# Conflicts:
#	packages/design-system/src/components/N8nCallout/Callout.vue
#	packages/editor-ui/src/App.vue
#	packages/editor-ui/src/plugins/i18n/locales/en.json
#	packages/editor-ui/src/stores/ui.store.ts
@janober
Copy link
Member

janober commented Jul 13, 2023

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released v1 Issues related to the release of n8n version 1.x.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants