fix: Restore expression completions #6566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/1.0.0 #6566 +/- ##
================================================
Coverage ? 28.66%
================================================
Files ? 2998
Lines ? 186256
Branches ? 20601
================================================
Hits ? 53384
Misses ? 132063
Partials ? 809 ☔ View full report in Codecov by Sentry. |
netroy
approved these changes
Jul 4, 2023
|
|
1 failed and 1 flaky tests on run #1377 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Credentials > should sort credentials |
Output
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 16 specs in Cypress Cloud.
cypress/e2e/25-stickies.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Canvas Actions > expands/shrinks sticky from the right edge |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 6, 2023
* master: (50 commits) fix(Google Drive Node): Fix regex in file RLC (#6607) feat(HTML Node): 'Convert to table operation (#6540) ci: e2e tests don't need to enable saving manual executions 🚀 Release 1.0.1 (#6606) fix(core): Make node execution order configurable, and backward-compatible (#6507) 🚀 Release 0.236.0 (#6602) fix: Fix migrations for postgres and mysql (no-changelog) (#6600) fix(core): Improve the performance of last 2 sqlite migrations (#6522) refactor: Switch cloud plan retrieval endpoint (no-changelog) (#6529) fix(Salesforce Node): Fix typo for adding a contact to a campaign (#6598) ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog) fix(editor): Restore expression completions (#6566) refactor: Remove basic auth env vars from docker compose stacks (#6570) fix(core): Fix migrations for MySQL/MariaDB (#6591) fix(editor): Show retry information in execution list only when it exists (#6587) fix(Strapi Node): Fix issue with pagination (#4991) fix(core): Route `/rest/workflows/new` correctly (no-changelog) (#6572) fix(XML Node): Fix issue with not returning valid data (#6565) fix(core): Fix credentials test (#6569) fix(core): Ensure valid `logger` is passed to every migration (no-changelog) (#6563) ... # Conflicts: # packages/design-system/src/components/N8nCallout/Callout.vue # packages/editor-ui/src/App.vue # packages/editor-ui/src/plugins/i18n/locales/en.json # packages/editor-ui/src/stores/ui.store.ts
MiloradFilipovic
added a commit
that referenced
this pull request
Jul 7, 2023
* ADO-814-trial-banner: (58 commits) ⚡ Updating permanent dismiss logic to work with all banners fix(editor): Make Source control branch select required (#6619) ⚡ Minor refactoring of banner logic refactor(core): Load `cookieParser` middleware only once (no-changelog) (#6614) fix(editor): Prevent keyboard shortcuts to edit workflows in readonly mode (#6613) fix(editor): Show appropriate empty workflow list content when instance environment is readonly (#6610) ✨ Implemented permanent/temporary dismiss logic for v1 flag ci: Fix linting issues (no-changelog) fix(Google Drive Node): Fix regex in file RLC (#6607) feat(HTML Node): 'Convert to table operation (#6540) ci: e2e tests don't need to enable saving manual executions 🚀 Release 1.0.1 (#6606) fix(core): Make node execution order configurable, and backward-compatible (#6507) 🚀 Release 0.236.0 (#6602) fix: Fix migrations for postgres and mysql (no-changelog) (#6600) fix(core): Improve the performance of last 2 sqlite migrations (#6522) refactor: Switch cloud plan retrieval endpoint (no-changelog) (#6529) fix(Salesforce Node): Fix typo for adding a contact to a campaign (#6598) ci: Hide v1 banner in e2e tests to fix 2-credentials.cy.ts (no-changelog) fix(editor): Restore expression completions (#6566) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression completions do not work on v1.0 because we are now surfacing all expression errors. This PR ensures expression completions utils that evaluate expressions do not throw when receiving unresolvable inputs.