Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add missing node parameter values to AI Assistant request #10788

Merged
merged 25 commits into from
Sep 17, 2024

Conversation

MiloradFilipovic
Copy link
Contributor

Summary

  • Adding missing values from referenced nodes (omitted by accident by passing true to getSchemaForExecutionData)
  • Adding direct node input to AI Assistant request
  • Adding resolved expression values to AI Assistant request
  • Refactoring referenced node detection to be more generic

Related Linear tickets, Github issues, and Community forum posts

Fixes ADO-2569
Fixes ADO-2570

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

* master:
  refactor(core): Revamp subworkflow policy checker errors (#10752)
  ci(benchmark): Add missing license cert (#10773)
  feat(editor): Show Collaboration pane only when there are multiple active users (#10772)
  🚀 Release 1.59.0 (#10775)
  feat: Add credential help to Assistant (no-changelog) (#10736)
  fix(editor): Fix error rendering and indexing of LLM sub-node outputs (#10688)
  feat(OpenAI Node): Add Max Tools Iteration parameter and prevent tool calling after execution is aborted (#10735)
  fix(editor): Revert remove tooltip from info tip (no-changelog) (#10771)
  refactor(editor): Enable collaboration features only in NodeView v2 (no-changelog) (#10756)
  fix(If Node): Update copy for type conversion parameter (#10769)
  build(core): Allow adding tests side by side with the code (#10760)

# Conflicts:
#	packages/editor-ui/src/stores/assistant.store.ts
* master:
  fix(core): Restore queue listeners for `webhook` process (#10781)
  refactor(benchmark): Rename scaling mode setups (#10783)
  refactor(core): Include AI events in log streaming relay (#10768)
  ci: Upgrade `validate-n8n-pull-request-title` to v2.2.0 (#10784)
  ci: Upgrade express to address CVE-2024-43796 (no-changelog) (#10785)
  fix(core): Fix the type for InstalledNodes.latestVersion (no-changelog) (#10782)
  fix(benchmark): Fix scaling mode setup (#10780)
@MiloradFilipovic MiloradFilipovic self-assigned this Sep 12, 2024
@MiloradFilipovic MiloradFilipovic changed the title Ai assistant node data improvements fix(editor): Add missing node parameter values to AI Assistant request Sep 12, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 12, 2024
packages/editor-ui/src/composables/useWorkflowHelpers.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/composables/useWorkflowHelpers.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/utils/nodeTypesUtils.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/utils/nodeTypesUtils.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/utils/nodeTypesUtils.ts Outdated Show resolved Hide resolved
packages/editor-ui/src/utils/nodeTypesUtils.ts Outdated Show resolved Hide resolved
* master:
  fix(editor): Fix completion on $input.item. in Code node (#10800)
  feat(OpenAI Node): Include O1 models in the models select (#10801)
  build: Disable `node-param-collection-type-unsorted-items` for langchain nodes (no-changelog) (#10802)
  fix(editor): Render the current first in CollaborationPane (no-changelog) (#10799)
  refactor(core): Enable import/order eslint rule (#10794)
  fix(benchmark): Fix benchmark license tenant (#10798)
  build: Upgrade nodelinter to 1.16.2 (no-changelog) (#10779)
  refactor(core): Migrate `Modal.vue` to composition API (no-changelog) (#10792)
  ci(benchmark): Run 3 times a night to account for fluctuations (#10791)
  refactor(editor): Convert `NodeExecuteButton` to composition api (#10703)
  refactor(benchmark): Use kebab-case for file and directory names (#10787)
* master:
  refactor(core): Set up worker server (#10814)
  fix(Google Vertex Chat Model Node): Clean service account private key (#10770)
  test(core): Mock filesystem in tests (#10823)
  test(core): Fix license mock in worker test (#10824)
  ci: Ignore certain paths for e2e tests for PRs (no-changelog) (#10533)
  fix(editor): Render image binary-data using img tags (#10829)
  refactor(core): Move `instanceType` to `InstanceSettings` (no-changelog) (#10640)
  ci(benchmark): Always perform az login before teardown (#10827)
  fix: Prevent copying workflow when copying outside of canvas (#10813)
  fix: Fix telemetry causing console error (#10828)
  refactor: Remove unused disable directives from `nodes-base` (#10825)
  refactor(core): Remove unused disable directives from backend packages (#10826)
  chore: Upgrade to TypeScript 5.6 (#10822)
  fix(editor): Prevent clipboard XSS injection (#10805)
  refactor(core): Simplify createDeferredPromise, and add tests (no-changelog) (#10811)
  fix(HTTP Request Tool Node): Fix subsequent tool calls reusung the same options (#10808)
  fix(editor): Make expression edit modal read-only in executions view (#10806)
  refactor(core): Move push message types to a new shared package (no-changelog) (#10742)
  fix(editor): Make schema view search copy more clear (#10807)
* master:
  ci: Setup biome and pre-commit hooks for formatting (no-changelog) (#10795)
  feat(editor): Add truncate directive (#10842)
  fix(editor): Allow custom git repo urls in source control settings (#10849)
  fix(Invoice Ninja Node): Fix lint error (no-changelog) (#10848)
  fix(editor): Minimap Show nodes outside viewport (#10843)
  fix(core): Prevent shutdown error in regular mode (#10844)
  feat(Invoice Ninja Node): Add actions for bank transactions (#10389)
  fix(editor): Address edge toolbar rendering glitches (#10839)
Copy link

cypress bot commented Sep 17, 2024

n8n    Run #6918

Run Properties:  status check passed Passed #6918  •  git commit acbc00fd05: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Project n8n
Branch Review ai-assistant-node-data-improvements
Run status status check passed Passed #6918
Run duration 04m 56s
Commit git commit acbc00fd05: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 MiloradFilipovic 🗃️ e2e/*
Committer Milorad Filipovic
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 430
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@MiloradFilipovic MiloradFilipovic merged commit d65ade4 into master Sep 17, 2024
33 checks passed
@MiloradFilipovic MiloradFilipovic deleted the ai-assistant-node-data-improvements branch September 17, 2024 14:14
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
@janober
Copy link
Member

janober commented Sep 18, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants