Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(If Node): Update copy for type conversion parameter #10769

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Sep 11, 2024

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1711/if-node-type-validation-copy-tweak

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Copy link

cypress bot commented Sep 11, 2024

n8n    Run #6832

Run Properties:  status check passed Passed #6832  •  git commit 24591126cb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project n8n
Branch Review node-1711-if-node-type-validation-copy-tweak
Run status status check passed Passed #6832
Run duration 04m 48s
Commit git commit 24591126cb: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Committer Elias Meire
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 427
View all changes introduced in this branch ↗︎

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request ui Enhancement in /editor-ui or /design-system labels Sep 11, 2024
Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link
Contributor

✅ All Cypress E2E specs passed

@elsmr elsmr merged commit ee5fbc5 into master Sep 11, 2024
32 checks passed
@elsmr elsmr deleted the node-1711-if-node-type-validation-copy-tweak branch September 11, 2024 12:12
@github-actions github-actions bot mentioned this pull request Sep 11, 2024
@Joffcom
Copy link
Member

Joffcom commented Sep 11, 2024

Got released with [email protected]

MiloradFilipovic added a commit that referenced this pull request Sep 12, 2024
* master:
  refactor(core): Revamp subworkflow policy checker errors (#10752)
  ci(benchmark): Add missing license cert (#10773)
  feat(editor): Show Collaboration pane only when there are multiple active users (#10772)
  🚀 Release 1.59.0 (#10775)
  feat: Add credential help to Assistant (no-changelog) (#10736)
  fix(editor): Fix error rendering and indexing of LLM sub-node outputs (#10688)
  feat(OpenAI Node): Add Max Tools Iteration parameter and prevent tool calling after execution is aborted (#10735)
  fix(editor): Revert remove tooltip from info tip (no-changelog) (#10771)
  refactor(editor): Enable collaboration features only in NodeView v2 (no-changelog) (#10756)
  fix(If Node): Update copy for type conversion parameter (#10769)
  build(core): Allow adding tests side by side with the code (#10760)

# Conflicts:
#	packages/editor-ui/src/stores/assistant.store.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants