fix(editor): Revert remove tooltip from info tip (no-changelog) #10771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomi
changed the title
n8n-assistant
bot
added
n8n team
OlegIvaniv
approved these changes
Sep 11, 2024
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
revert-remove-tooltip-from-info-tip
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | Tomi Turtiainen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
427
|
| View all changes introduced in this branch ↗︎ | |
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 12, 2024
* master: refactor(core): Revamp subworkflow policy checker errors (#10752) ci(benchmark): Add missing license cert (#10773) feat(editor): Show Collaboration pane only when there are multiple active users (#10772) 🚀 Release 1.59.0 (#10775) feat: Add credential help to Assistant (no-changelog) (#10736) fix(editor): Fix error rendering and indexing of LLM sub-node outputs (#10688) feat(OpenAI Node): Add Max Tools Iteration parameter and prevent tool calling after execution is aborted (#10735) fix(editor): Revert remove tooltip from info tip (no-changelog) (#10771) refactor(editor): Enable collaboration features only in NodeView v2 (no-changelog) (#10756) fix(If Node): Update copy for type conversion parameter (#10769) build(core): Allow adding tests side by side with the code (#10760) # Conflicts: # packages/editor-ui/src/stores/assistant.store.ts
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tooltip mode is indeed used in multiple location, hence it can't be removed.
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)