fix(editor): Minimap Show nodes outside viewport #10843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r00gm
changed the title
n8n-assistant
bot
added
n8n team
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
n8n-7692-minimap-isnt-useful-since-doesnt-show-nodes-outside-the
|
| Run status |
|
| Run duration | 04m 44s |
| Commit |
|
| Committer | r00gm |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
430
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
r00gm
deleted the
n8n-7692-minimap-isnt-useful-since-doesnt-show-nodes-outside-the
branch
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 17, 2024
* master: ci: Setup biome and pre-commit hooks for formatting (no-changelog) (#10795) feat(editor): Add truncate directive (#10842) fix(editor): Allow custom git repo urls in source control settings (#10849) fix(Invoice Ninja Node): Fix lint error (no-changelog) (#10848) fix(editor): Minimap Show nodes outside viewport (#10843) fix(core): Prevent shutdown error in regular mode (#10844) feat(Invoice Ninja Node): Add actions for bank transactions (#10389) fix(editor): Address edge toolbar rendering glitches (#10839)
Merged
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to the selected color palette event though nodes outside the viewport were rendered in the minimap it was imposible to distinguish them from the background
Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/N8N-7692/minimap-isnt-useful-since-doesnt-show-nodes-outside-the-viewport
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)