⚡ Resolving assistant expressions using default values

n8n-io · Sep 17, 2024 · acbc00f · acbc00f
1 parent 621e70a
commit acbc00f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/packages/editor-ui/src/composables/useWorkflowHelpers.ts b/packages/editor-ui/src/composables/useWorkflowHelpers.ts
@@ -712,20 +712,7 @@ export function useWorkflowHelpers(options: { router: ReturnType<typeof useRoute
 					// Resolve the expression if it is one
 					let resolved;
 					try {
-						let opts: Parameters<typeof resolveExpression>[2] = {
-							isForCredential: false,
-						};
-						const ndvStore = useNDVStore();
-						if (ndvStore.isInputParentOfActiveNode) {
-							opts = {
-								...opts,
-								targetItem: ndvStore.expressionTargetItem ?? undefined,
-								inputNodeName: ndvStore.ndvInputNodeName,
-								inputRunIndex: ndvStore.ndvInputRunIndex,
-								inputBranchIndex: ndvStore.ndvInputBranchIndex,
-							};
-						}
-						resolved = resolveExpression(value, undefined, opts);
+						resolved = resolveExpression(value, undefined, { isForCredential: false });
 					} catch (error) {
 						resolved = `Error in expression: "${error.message}"`;
 					}

diff --git a/packages/editor-ui/src/utils/__tests__/nodeTypesUtils.spec.ts b/packages/editor-ui/src/utils/__tests__/nodeTypesUtils.spec.ts
@@ -308,8 +308,7 @@ const referencedNodesTestCases: Array<{ caseName: string; node: INode; expected:
 			parameters: {
 				curlImport: '',
 				method: 'GET',
-				// eslint-disable-next-line prettier/prettier
-				url: "={{ $(`Edit \\`Fields\\` 2`).item.json.name }}",
+				url: '={{ $(`Edit \\`Fields\\` 2`).item.json.name }}',
 				authentication: 'none',
 				provideSslCertificates: false,
 				sendQuery: false,