fix(editor): Render the current first in CollaborationPane (no-changelog) #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
tomi
reviewed
Sep 12, 2024
|
✅ All Cypress E2E specs passed |
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
CollaborationPane-correct-order
|
| Run status |
|
| Run duration | 04m 43s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
2
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
429
|
| View all changes introduced in this branch ↗︎ | |
MiloradFilipovic
added a commit
that referenced
this pull request
Sep 13, 2024
* master: fix(editor): Fix completion on $input.item. in Code node (#10800) feat(OpenAI Node): Include O1 models in the models select (#10801) build: Disable `node-param-collection-type-unsorted-items` for langchain nodes (no-changelog) (#10802) fix(editor): Render the current first in CollaborationPane (no-changelog) (#10799) refactor(core): Enable import/order eslint rule (#10794) fix(benchmark): Fix benchmark license tenant (#10798) build: Upgrade nodelinter to 1.16.2 (no-changelog) (#10779) refactor(core): Migrate `Modal.vue` to composition API (no-changelog) (#10792) ci(benchmark): Run 3 times a night to account for fluctuations (#10791) refactor(editor): Convert `NodeExecuteButton` to composition api (#10703) refactor(benchmark): Use kebab-case for file and directory names (#10787)
|
Got released with |
riascho
pushed a commit
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the CollaborationPane to show the current user at the top of the list, instead of the instance owner.
Review / Merge checklist