Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Migrate GoSDK to main repo as Milvus Client #31293

Open
1 task done
congqixia opened this issue Mar 15, 2024 · 0 comments
Open
1 task done

[Feature]: Migrate GoSDK to main repo as Milvus Client #31293

congqixia opened this issue Mar 15, 2024 · 0 comments
Assignees
@congqixia
Labels
kind/feature Issues related to feature request from users

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Migrate GoSDK to main repo as Milvus Client

Describe the solution you'd like.

Add github.com/milvus-io/milvus/client/v2 pkg as a go sub module in main repo

Describe an alternate solution.

use https://github.com/milvus-io/milvus-sdk-go

Anything else? (Additional Context)

No response
@congqixia congqixia added the kind/feature Issues related to feature request from users label Mar 15, 2024
@congqixia congqixia self-assigned this Mar 15, 2024
congqixia added a commit to congqixia/milvus that referenced this issue Mar 15, 2024
@congqixia
feat: Add workflow and rules for client pkg
c520db4 
See also milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Mar 15, 2024
Closed
congqixia added a commit to congqixia/milvus that referenced this issue May 9, 2024
@congqixia
feat: Add milvusclient package and migrate GoSDK
1989bdb 
Related to milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue May 9, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 10, 2024
@congqixia
feat: Add milvusclient package and migrate GoSDK (#32907)
244d2c0 
Related to #31293

Signed-off-by: Congqi Xia <[email protected]>
UnyieldingOrca pushed a commit to UnyieldingOrca/milvus that referenced this issue May 10, 2024
@congqixia
feat: Add milvusclient package and migrate GoSDK (milvus-io#32907)
2a6f634 
Related to milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue May 11, 2024
@congqixia
enhance: Sync go.mod version & dep to main pkg
e27c729 
Related to milvus-io#31293
See also milvus-io#32951 milvus-io#32952 milvus-io#32953 milvus-io#32954

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue May 11, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 13, 2024
@congqixia
enhance: Sync go.mod version & dep to main pkg (#32973)
ef41f80 
Related to #31293
See also #32951 #32952 #32953 #32954

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue May 16, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 17, 2024
@congqixia
enhance: Update latest sdk update to client pkg (#33105)
1ef975d 
Related to #31293
See also milvus-io/milvus-sdk-go#704 milvus-io/milvus-sdk-go#711 
milvus-io/milvus-sdk-go#713 milvus-io/milvus-sdk-go#721
milvus-io/milvus-sdk-go#732 milvus-io/milvus-sdk-go#739 
milvus-io/milvus-sdk-go#748

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue May 20, 2024
@congqixia
enhance: Add lint rules for client pkg and fix problems
e7e0229 
See also milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue May 20, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 20, 2024
@congqixia
enhance: Add lint rules for client pkg and fix problems (#33180)
7eeb120 
See also #31293

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue May 22, 2024
@congqixia
enhance: Support Row-based insert for milvusclient
3a85ad9 
See also milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue May 22, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue May 22, 2024
@congqixia
enhance: Support Row-based insert for milvusclient (#33270)
33144a4 
See also #31293

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Jun 6, 2024
@congqixia
fix: Make fp16&bf16 column use correct byte lenght
638a652 
See also milvus-io/milvus-sdk-go#756 milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jun 6, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 7, 2024
@congqixia
fix: Make fp16&bf16 column use correct byte length (#33684)
60baaed 
See also milvus-io/milvus-sdk-go#756 #31293

Signed-off-by: Congqi Xia <[email protected]>

Signed-off-by: Congqi Xia <[email protected]>
@forsaken628 forsaken628 mentioned this issue Jun 19, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Jun 20, 2024
@congqixia
enhance: Add rules and fix for go_client e2e code style
d072076 
See also milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jun 20, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jun 21, 2024
@congqixia
enhance: Add rules and fix for go_client e2e code style (#34033)
35ea775 
See also #31293

---------

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Jun 21, 2024
@forsaken628
enhance: Support queryOption WithLimit for milvusclient (#33978)
6671000 
See also #31293

---------

Signed-off-by: coldWater <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Jul 1, 2024
@congqixia
enhance: Sync IndexType supported from v1
8300af0 
See also milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Jul 1, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Jul 1, 2024
@congqixia
enhance: [GoSDK] Sync IndexType supported from v1 (#34310)
87bccb1 
See also #31293

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 1, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Nov 5, 2024
@congqixia
enhance: [GoSDK] Add alter collection API & expose options
55a5c50 
Related to milvus-io#31293

This PR:

- Add `AlterCollection` API for collection property modification
- Expose hidden or missing option methods

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Nov 6, 2024
@congqixia
enhance: [GoSDK] Add alter collection API & expose options (#37365)
c83b939 
Related to #31293

This PR:

- Add `AlterCollection` API for collection property modification
- Expose hidden or missing option methods

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 6, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 7, 2024
@congqixia
enhance: [GoSDK] Remove example in main pkg to make ut script work (#…
f813fb4 
…37472)

Related to #31293

Example with main func/package causes `go list` command failed with vcs
error. This PR removes example files with main package. The example
snippet shall be added back in runnable test format.

---------

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 7, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 7, 2024
@congqixia
enhance: [GoSDK] move client pkg go files to sub one (#37492)
11f4fe0 
Related to #31293

Client source files under client pkg cannot be evaluate correctly by
codecov. This PR moves them to `milvusclient` sub-package to fix this
issue and follow go major version best practice.

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Nov 18, 2024
@congqixia
enhance: [GoSDK] Use generic column base and add unit tests
39c8d19 
Related to milvus-io#31293

Previous column is written using go before 1.18, which does not support
generic type. After migrating client pkg to main repo, generic base
could be used to reduce lots of duplicated code.

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 18, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 19, 2024
@congqixia
enhance: [GoSDK] Use generic column base and add unit tests (#37768)
175f49e 
Related to #31293

Previous column is written using go before 1.18, which does not support
generic type. After migrating client pkg to main repo, generic base
could be used to reduce lots of duplicated code.

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Nov 28, 2024
@congqixia
enhance: [GoSDK] Support nullable generic column
0c1f51f 
Related to milvus-io#31728 milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Nov 28, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Nov 29, 2024
@congqixia
enhance: [GoSDK] Support nullable generic column (#38076)
fd94f12 
Related to #31728 #31293

---------

Signed-off-by: Congqi Xia <[email protected]>
wayblink pushed a commit to wayblink/milvus that referenced this issue Nov 29, 2024
@congqixia @wayblink
enhance: [GoSDK] Support nullable generic column (milvus-io#38076)
f166cd4 
Related to milvus-io#31728 milvus-io#31293

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Dec 16, 2024
@congqixia
enhance: [GoSDK] Add bulk import restful API wrapper
d79c042 
Related to milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Dec 16, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Dec 17, 2024
@congqixia
enhance: [GoSDK] Add bulk import restful API wrapper
25b10da 
Related to milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Dec 17, 2024
@congqixia
enhance: [GoSDK] Refine search params and add some examples
e5c70c3 
Related to milvus-io#31293

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Dec 17, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 17, 2024
@congqixia
enhance: [GoSDK] Add bulk import restful API wrapper (#38493)
e19a4f7 
Related to #31293

---------

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Dec 17, 2024
@congqixia
enhance: [GoSDK] Refine search params and add some examples (#38523)
1ec8584 
Related to #31293

This PR
- Add some example test code for some basic operations
- Refine search params and add some predefined one
- Split search & hybrid search option

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Dec 19, 2024
@congqixia
enhance: [GoSDK] Add content-type header for bulk import req
5a419d9 
Related to milvus-io#31293
Previous PR: milvus-io#38493

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Dec 19, 2024
Merged
congqixia added a commit to congqixia/milvus that referenced this issue Dec 19, 2024
@congqixia
enhance: [GoSDK] Sync API names and add missing APIs
a1ed98d 
Related to milvus-io#31293

- Rename `UsingDatabase` to `UseDatabase`
- Uncomment default value methods
- Add missing RBAC APIs
- Add some resource group APIs

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Dec 19, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 20, 2024
@congqixia
enhance: [GoSDK] Add content-type header for bulk import req (#38581)
a728646 
Related to #31293
Previous PR: #38493

Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Dec 20, 2024
@congqixia
enhance: [GoSDK] Sync API names and add missing APIs (#38603)
c39db11 
Related to #31293

- Rename `UsingDatabase` to `UseDatabase`
- Uncomment default value methods
- Add missing RBAC APIs
- Add some resource group APIs

---------

Signed-off-by: Congqi Xia <[email protected]>
congqixia added a commit to congqixia/milvus that referenced this issue Dec 27, 2024
@congqixia
enhance: [GoSDK] Support alter properties APIs
fb8b623 
Related to milvus-io#31293

This PR:

- Add AlterDatabaseProperties API
- Add DropDatabaseProperties API
- Add DescribeDatabase API
- Rename AlterCollection to AlterCollectionProperties
- Add DropCollectionProperties API
- Add AlterCollectionFieldProperties API

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia mentioned this issue Dec 27, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Dec 27, 2024
@congqixia
enhance: [GoSDK] Support alter properties APIs (#38812)
c39452f 
Related to #31293

This PR:

- Add AlterDatabaseProperties API
- Add DropDatabaseProperties API
- Add DescribeDatabase API
- Rename AlterCollection to AlterCollectionProperties
- Add DropCollectionProperties API
- Add AlterCollectionFieldProperties API

Signed-off-by: Congqi Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@congqixia congqixia

Labels
kind/feature Issues related to feature request from users
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@congqixia