Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [GoSDK] move client pkg go files to sub one #37492

Merged
merged 3 commits into from
Nov 7, 2024
Merged

enhance: [GoSDK] move client pkg go files to sub one #37492

merged 3 commits into from
Nov 7, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Nov 7, 2024 •
edited
Loading

Related to #31293

Client source files under client pkg cannot be evaluate correctly by codecov. This PR moves them to milvusclient sub-package to fix this issue and follow go major version best practice.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. approved labels Nov 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia
Copy link
Contributor Author

rerun go-sdk

@sre-ci-robot sre-ci-robot added area/test sig/testing size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.30%. Comparing base (7cfd609) to head (26f5849).
Report is 21 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37492       +/-   ##
===========================================
- Coverage   83.23%   67.30%   -15.94%     
===========================================
  Files        1015      290      -725     
  Lines      157697    25400   -132297     
===========================================
- Hits       131260    17095   -114165     
+ Misses      21228     8305    -12923     
+ Partials     5209        0     -5209
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.30% <47.76%> (∅)
Go ∅ <ø> (∅)

see 1305 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
enhance: [GoSDK] move client pkg go files to sub one
51d7568 
Client source files under client pkg cannot be evaluate correctly by
codecov. This PR moves them to `milvusclient` sub-package to fix this
issue and follow go major version best practice.

Signed-off-by: Congqi Xia <[email protected]>
@congqixia
Fix testcase import
2115181 
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/move_clientpkg branch from 92797f4 to 2115181 Compare November 7, 2024 06:36
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

@congqixia
Fix datacoord mockery
26f5849 
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 7, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 7, 2024
@congqixia
Copy link
Contributor Author

/hold

ThreadDao
ThreadDao reviewed Nov 7, 2024
View reviewed changes
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@congqixia
Copy link
Contributor Author

/unhold

@sre-ci-robot sre-ci-robot merged commit 11f4fe0 into milvus-io:master Nov 7, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThreadDao ThreadDao ThreadDao left review comments

@sunby sunby Awaiting requested review from sunby

Assignees

@ThreadDao ThreadDao

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @ThreadDao