fix: Make fp16&bf16 column use correct byte length (#33684)

See also milvus-io/milvus-sdk-go#756 #31293 Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Jun 7, 2024 · 60baaed · 60baaed
1 parent 6ce9df9
commit 60baaed
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 14 deletions.
diff --git a/client/column/columns.go b/client/column/columns.go
@@ -281,12 +281,12 @@ func FieldDataColumn(fd *schemapb.FieldData, begin, end int) (Column, error) {
 		data := x.Float16Vector
 		dim := int(vectors.GetDim())
 		if end < 0 {
-			end = len(data) / dim
+			end = len(data) / dim / 2
 		}
 		vector := make([][]byte, 0, end-begin)
 		for i := begin; i < end; i++ {
-			v := make([]byte, dim)
-			copy(v, data[i*dim:(i+1)*dim])
+			v := make([]byte, dim*2)
+			copy(v, data[i*dim*2:(i+1)*dim*2])
 			vector = append(vector, v)
 		}
 		return NewColumnFloat16Vector(fd.GetFieldName(), dim, vector), nil
@@ -300,12 +300,12 @@ func FieldDataColumn(fd *schemapb.FieldData, begin, end int) (Column, error) {
 		data := x.Bfloat16Vector
 		dim := int(vectors.GetDim())
 		if end < 0 {
-			end = len(data) / dim
+			end = len(data) / dim / 2
 		}
 		vector := make([][]byte, 0, end-begin) // shall not have remanunt
 		for i := begin; i < end; i++ {
 			v := make([]byte, dim)
-			copy(v, data[i*dim:(i+1)*dim])
+			copy(v, data[i*dim*2:(i+1)*dim*2])
 			vector = append(vector, v)
 		}
 		return NewColumnBFloat16Vector(fd.GetFieldName(), dim, vector), nil

diff --git a/client/column/columns_test.go b/client/column/columns_test.go
@@ -39,14 +39,13 @@ func TestIDColumns(t *testing.T) {
 	)
 
 	t.Run("nil id", func(t *testing.T) {
-		col, err := IDColumns(intPKCol, nil, 0, -1)
-		assert.NoError(t, err)
-		assert.EqualValues(t, 0, col.Len())
-		col, err = IDColumns(strPKCol, nil, 0, -1)
-		assert.NoError(t, err)
-		assert.EqualValues(t, 0, col.Len())
+		_, err := IDColumns(intPKCol, nil, 0, -1)
+		assert.Error(t, err)
+		_, err = IDColumns(strPKCol, nil, 0, -1)
+		assert.Error(t, err)
+
 		idField := &schemapb.IDs{}
-		col, err = IDColumns(intPKCol, idField, 0, -1)
+		col, err := IDColumns(intPKCol, idField, 0, -1)
 		assert.NoError(t, err)
 		assert.EqualValues(t, 0, col.Len())
 		col, err = IDColumns(strPKCol, idField, 0, -1)

diff --git a/client/column/vector_gen.go b/client/column/vector_gen.go