Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Sync API names and add missing APIs #38603

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

congqixia
Copy link
Contributor

Related to #31293

  • Rename UsingDatabase to UseDatabase
  • Uncomment default value methods
  • Add missing RBAC APIs
  • Add some resource group APIs

Related to milvus-io#31293

- Rename `UsingDatabase` to `UseDatabase`
- Uncomment default value methods
- Add missing RBAC APIs
- Add some resource group APIs

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. approved labels Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 93.15589% with 36 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (c0b855d) to head (41ae809).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
client/milvusclient/read_options.go 52.94% 16 Missing ⚠️
client/milvusclient/maintenance_options.go 90.16% 6 Missing ⚠️
client/milvusclient/rbac.go 94.64% 4 Missing and 2 partials ⚠️
client/entity/field.go 0.00% 3 Missing ⚠️
client/milvusclient/maintenance.go 95.45% 2 Missing and 1 partial ⚠️
client/milvusclient/read.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38603      +/-   ##
==========================================
+ Coverage   81.00%   81.04%   +0.04%     
==========================================
  Files        1379     1381       +2     
  Lines      194524   195087     +563     
==========================================
+ Hits       157572   158114     +542     
- Misses      31395    31413      +18     
- Partials     5557     5560       +3     
Components Coverage Δ
Client 78.24% <93.15%> (+2.36%) ⬆️
Core 69.33% <ø> (ø)
Go 83.03% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
client/milvusclient/collection.go 90.56% <100.00%> (+1.31%) ⬆️
client/milvusclient/collection_options.go 97.20% <100.00%> (+0.12%) ⬆️
client/milvusclient/database.go 100.00% <100.00%> (+13.33%) ⬆️
client/milvusclient/database_options.go 100.00% <100.00%> (+23.07%) ⬆️
client/milvusclient/partition.go 100.00% <100.00%> (ø)
client/milvusclient/partition_options.go 100.00% <100.00%> (ø)
client/milvusclient/rbac_options.go 100.00% <100.00%> (ø)
client/milvusclient/resource_group.go 100.00% <100.00%> (ø)
client/milvusclient/resource_group_option.go 100.00% <100.00%> (ø)
client/milvusclient/read.go 72.09% <0.00%> (-0.85%) ⬇️
... and 5 more

... and 25 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 19, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 20, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit c39db11 into milvus-io:master Dec 20, 2024
19 of 20 checks passed
@congqixia congqixia deleted the enhance/gosdk/sync_apis branch December 23, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants