Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [GoSDK] Add alter collection API & expose options #37365

Merged
merged 3 commits into from
Nov 6, 2024
Merged

enhance: [GoSDK] Add alter collection API & expose options #37365

merged 3 commits into from
Nov 6, 2024

Conversation

congqixia
Copy link
Contributor

Related to #31293

This PR:

  • Add AlterCollection API for collection property modification
  • Expose hidden or missing option methods

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Nov 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 1, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (9a0e1c8) to head (45cfbc0).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37365      +/-   ##
==========================================
- Coverage   83.26%   81.00%   -2.27%     
==========================================
  Files        1015     1305     +290     
  Lines      157473   182909   +25436     
==========================================
+ Hits       131121   148166   +17045     
- Misses      21163    29540    +8377     
- Partials     5189     5203      +14
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.19% <100.00%> (∅)
Go 83.26% <ø> (-0.03%) ⬇️

see 327 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
enhance: [GoSDK] Add alter collection API & expose options
55a5c50 
Related to milvus-io#31293

This PR:

- Add `AlterCollection` API for collection property modification
- Expose hidden or missing option methods

Signed-off-by: Congqi Xia <[email protected]>
@congqixia
Fix go sdk e2e case
1e8c8f9 
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/add_alter_coll_options branch from c9138ec to 1e8c8f9 Compare November 5, 2024 10:20
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 6, 2024
ThreadDao
ThreadDao reviewed Nov 6, 2024
View reviewed changes
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit c83b939 into milvus-io:master Nov 6, 2024
19 of 20 checks passed
@congqixia congqixia deleted the enhance/add_alter_coll_options branch November 6, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThreadDao ThreadDao ThreadDao left review comments

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@ThreadDao ThreadDao

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @ThreadDao