Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Sync IndexType supported from v1 #34310

Merged

Conversation

congqixia
Copy link
Contributor

See also #31293

@sre-ci-robot sre-ci-robot requested review from czs007 and ThreadDao July 1, 2024 11:04
@congqixia congqixia changed the title enhance: Sync IndexType supported from v1 enhance: [GoSDK] Sync IndexType supported from v1 Jul 1, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 1, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 1, 2024
client/index/ivf.go Outdated Show resolved Hide resolved
client/index/ivf.go Outdated Show resolved Hide resolved
Signed-off-by: Congqi Xia <[email protected]>
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify mergify bot added the ci-passed label Jul 1, 2024
@sre-ci-robot sre-ci-robot merged commit 87bccb1 into milvus-io:master Jul 1, 2024
10 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants