Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship newer version of conpty #224488

Open
Tyriar opened this issue Aug 1, 2024 · 2 comments
Open

Ship newer version of conpty #224488

Tyriar opened this issue Aug 1, 2024 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal-conpty Integrated terminal issues related to the ConPTY backend windows VS Code on Windows issues
Milestone
On Deck

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 1, 2024 •
edited
Loading

We currently depend on conpty as shipped by Windows. Unfortunately this means that fixes in conpty can take 1-2 years to make it to the user, provided they update to it. We want to ship conpty.dll similar to how Windows Terminal/wezterm does so we get all the latest improvements.

Many issues get closed as duplicates of this one as updating to conpty v2 will fix many problems in Windows terminals.

node-pty issue: microsoft/node-pty#490
@Tyriar Tyriar added feature-request Request for new features or functionality windows VS Code on Windows issues labels Aug 1, 2024
@Tyriar Tyriar added this to the August 2024 milestone Aug 1, 2024
@Tyriar Tyriar self-assigned this Aug 1, 2024
@Tyriar Tyriar mentioned this issue Aug 1, 2024
Merged
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 1, 2024
@Tyriar
Ship third_party folder with module
7c4e9ed 
This needs to be there to copy over the right binary on postinstall

Part of microsoft/vscode#224488
This was referenced Aug 1, 2024
Merged
Merged
Merged
Merged
Closed
Tyriar added a commit that referenced this issue Aug 5, 2024
@Tyriar
Update to node-pty and adopt useConptyDll
fe1bb56 
Part of #224488
@Tyriar Tyriar mentioned this issue Aug 5, 2024
Merged
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 5, 2024
@Tyriar
Improve can't find conpty.dll exception message
98d8566 
Part of microsoft/vscode#224488
@Tyriar Tyriar mentioned this issue Aug 5, 2024
Merged
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 6, 2024
@Tyriar
Get path of conpty.node for conpty.dll
cf62104 
Part of microsoft/vscode#224488
This was referenced Aug 6, 2024
Merged
Merged
Tyriar added a commit that referenced this issue Aug 7, 2024
@Tyriar
Update conpty.dll
7873057 
Part of #224488
@Tyriar Tyriar mentioned this issue Aug 7, 2024
Merged
Tyriar added a commit that referenced this issue Aug 7, 2024
@Tyriar
Don't pack conpty binaries into asar
ed73b9d 
Part of #224488
This was referenced Aug 7, 2024
Merged
Closed
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 9, 2024
@Tyriar
Fix correct method being loaded when not using conptydll
ef1cefc 
Part of microsoft/vscode#224488
@Tyriar Tyriar mentioned this issue Aug 9, 2024
Merged
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 11, 2024
@Tyriar
Copy right dll/exe based on npm_config_arch
211e251 
Part of microsoft/vscode#224488
Tyriar added a commit to microsoft/node-pty that referenced this issue Aug 11, 2024
@Tyriar
Copy right dll/exe based on npm_config_arch
4f2f641 
Part of microsoft/vscode#224488
Part of microsoft/vscode#225355
@Tyriar Tyriar mentioned this issue Aug 11, 2024
Merged
@kieferrm kieferrm mentioned this issue Aug 12, 2024
Closed
56 tasks
@Tyriar
Copy link
Member Author

Tyriar commented Aug 26, 2024

This will ship as an experimental setting terminal.integrated.experimental.windowsUseConptyDll in 1.93. Will push this to September and reconsider removing experimental then. I don't think a test plan item will be useful over passive testing from self hosting.

This was referenced Dec 10, 2024
Closed
Open
Open
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal-conpty Integrated terminal issues related to the ConPTY backend windows VS Code on Windows issues
Projects
None yet
Milestone
On Deck
Development

No branches or pull requests
1 participant
@Tyriar