Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node-pty and adopt useConptyDll #224854

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Update to node-pty and adopt useConptyDll #224854

merged 7 commits into from
Aug 6, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 5, 2024

Part of #224488

@Tyriar Tyriar added this to the August 2024 milestone Aug 5, 2024
@Tyriar Tyriar self-assigned this Aug 5, 2024
@Tyriar Tyriar marked this pull request as ready for review August 6, 2024 12:53
@Tyriar
Copy link
Member Author

Tyriar commented Aug 6, 2024

Looks like it's working 🎉

image

@Tyriar
Copy link
Member Author

Tyriar commented Aug 6, 2024

I'm also seeing shell integration decorations being much more reliable

bpasero
bpasero previously approved these changes Aug 6, 2024
@Tyriar Tyriar merged commit 5275859 into main Aug 6, 2024
6 checks passed
@Tyriar Tyriar deleted the tyriar/conptydll branch August 6, 2024 15:10
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants