Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command highlight shows incorrect height when the original command is wrapped #200602

Closed
amio opened this issue Dec 12, 2023 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone

Comments

@amio
Copy link

amio commented Dec 12, 2023

Does this issue occur when all extensions are disabled?: Yes

Versions

Version: 1.85.0
Commit: af28b32
Date: 2023-12-06T18:17:50.719Z
Electron: 25.9.7
ElectronBuildId: 25551756
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.1.0

Steps to Reproduce

  1. execute a long command that wraps
  2. hover to the command image
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal-rendering labels Dec 14, 2023
@joyceerhl
Copy link
Collaborator

On Windows I can repro for certain shells, e.g. this repros for Git Bash and not for pwsh

@Tyriar Tyriar added this to the Backlog milestone Dec 15, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2024

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.

If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Additionally, soon we plan on shipping conpty v2 with VS Code which should bring our behavior in line with Windows Terminal. Thanks for understanding.

/label upstream terminal-conpty windows

@Tyriar Tyriar closed this as completed Dec 10, 2024
@vs-code-engineering vs-code-engineering bot added upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues terminal-conpty Integrated terminal issues related to the ConPTY backend labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

3 participants