Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sixel support does not work on Windows #198622

Closed
utybo opened this issue Nov 19, 2023 · 4 comments · Fixed by #235752
Closed

Sixel support does not work on Windows #198622

utybo opened this issue Nov 19, 2023 · 4 comments · Fixed by #235752
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering
Milestone

Comments

@utybo
Copy link

utybo commented Nov 19, 2023

Type: Bug

With the following settings:

  • Terminal > Integrated: Enable Images enabled
  • Integrated: Gpu Acceleration set to on
  • Terminal > Integrated: Windows Enable Conpty set to on (default)

I can't seem to get images displayed correctly in the integrated terminal. Via pwsh, trying cat snake.six (the one from libsixel, downloaded from GitHub) only prints a blank line. Here are commands I've tried: none of them print any image:

  • In pwsh, cat <a sixel image downloaded>
  • In WSL, img2sixel <some PNG> and curl -s https://raw.githubusercontent.com/saitoha/libsixel/master/images/snake.six && echo

Did I do something wrong? How do I make Sixel support work? I couldn't find any information on Windows while digging in a few places.

NB: Tabby, which also uses xterm.js, claim that Sixel support straight up does not work on Windows because of ConPTY (Eugeny/tabby#7063), while the help for the Enable Images option says that it should work on Windows

image

Screenshots

image

image

Everything else

VS Code version: Code 1.84.2 (1a5daa3, 2023-11-09T10:51:52.184Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info
Item Value
CPUs AMD Ryzen 5 3600X 6-Core Processor (12 x 3793)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 31.91GB (18.39GB free)
Process Argv --disable-extensions --crash-reporter-id e9c2325f-b28a-415b-9f99-a36273b50ae8
Screen Reader no
VM 0%
Extensions disabled
A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
py29gd2263:30880072
vscaac:30438847
vsclangdf:30486550
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
f6dab269:30613381
2i9eh265:30646982
showlangstatbar:30737416
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
welcomedialogc:30887144
pythonnosmt12:30797651
pythonidxpt:30866567
pythonnoceb:30805159
synctok:30869157
dsvsc013:30795093
dsvsc014:30804076
dsvsc015:30845448
pythontestfixtcf:30871695
pythonregdiag2:30871582
pyreplss2:30886141
pythonmypyd1:30879173
pythoncet0:30885854
pythontbext0:30879054
accentitlementst:30887150
dsvsc016cf:30886111
dsvsc017cf:30886113
dsvsc018cf:30886115
aa_t_chat:30882232

@pheizaut
Copy link

As per this comment seems it's an ANSI related issue.
On a Windows 11 machine just enabling it globally got it working.
On my Windows 10 for some reason this sequence gets stripped out �]1337;File=inline=1;size=1282;name=Y3JvcHBlZC5wbmc=;height=3:
which I found a workaround by just doing
imgcat img.png > output.txt && cat output.txt

Only seems to work for small images.

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug terminal-rendering labels Dec 14, 2023
@jiwonz
Copy link

jiwonz commented Aug 8, 2024

Bump. I'm having the same issue, but it works fine in msys2 terminal and mintty.

@Tyriar
Copy link
Member

Tyriar commented Aug 8, 2024

I believe support for this is coming soon in Windows Terminal which means we will get it soon as we're finally about to start shipping a newer version of conpty #224488

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Aug 8, 2024
@Tyriar Tyriar added this to the Backlog milestone Aug 8, 2024
@Tyriar Tyriar modified the milestones: Backlog, January 2025 Dec 10, 2024
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2024

To verify check the setting description for enableImages and windowsUseConptyDll.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) feature-request Request for new features or functionality labels Dec 10, 2024
@Tyriar Tyriar closed this as completed in a5539ae Dec 10, 2024
@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal-rendering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants