Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git Bash Terminal input is blocked after edit #193809

Closed
Trass3r opened this issue Sep 22, 2023 · 8 comments
Closed

Git Bash Terminal input is blocked after edit #193809

Trass3r opened this issue Sep 22, 2023 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmation-pending *not-reproducible Issue cannot be reproduced by VS Code Team member as described windows VS Code on Windows issues

Comments

@Trass3r
Copy link

Trass3r commented Sep 22, 2023

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.82.2
  • OS Version: Win10 22H2

Steps to Reproduce:

I'm using a Git Bash Terminal (https://gitforwindows.org/ 2.42.0.2 with default install options) inside VSCode and the git setting git config core.editor 'code --wait'.
When I run git add -p and then enter e it correctly opens the patch in the same VSCode window for editing and after closing progresses in the terminal to the next hunk.
Scrolling etc is still possible but it doesn't accept any input anymore.
Ctrl+C etc has no effect. The only way to exit this deadlock is to kill the terminal, but that also leaves the git index untouched.

@Trass3r Trass3r changed the title Git Bash Terminal is frozen after edit Git Bash Terminal input is blocked after edit Sep 22, 2023
@Trass3r
Copy link
Author

Trass3r commented Sep 22, 2023

Just cross-checked, it doesn't happen with the default Command Prompt. It's some issue related to the Git mintty.

@Tyriar Tyriar added windows VS Code on Windows issues confirmation-pending labels Sep 25, 2023
@joyceerhl
Copy link
Collaborator

I cannot repro this with Git Bash, does this still occur reliably for you?

@joyceerhl joyceerhl added the info-needed Issue requires more information from poster label Dec 13, 2023
@Trass3r
Copy link
Author

Trass3r commented Dec 14, 2023

Yes it does. The profile config looks default too. It auto-detected the git bash and I can directly open it inside VSCode.

@joyceerhl joyceerhl removed the info-needed Issue requires more information from poster label Dec 14, 2023
@ars-con
Copy link

ars-con commented Aug 21, 2024

I'm also having this exact issue.

VS Code 1.92.1, Git 2.46.0

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Dec 18, 2024
@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2024

I also can't reproduce so unfortunately this isn't actionable and closing. Something that could improve this you could try is to move to the new backend on Windows by setting "terminal.integrated.experimental.windowsUseConptyDll": true and restarting the terminal. Other than that I'm not sure, this sort of problem is largely out of our hands as we as the terminal just do as we're told by the process running on the other side.

@Tyriar Tyriar closed this as completed Dec 19, 2024
@Tyriar Tyriar added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Dec 19, 2024
@Trass3r
Copy link
Author

Trass3r commented Dec 19, 2024

Unfortunately windowsUseConptyDll doesn't fix it.
I also upgraded to the newest Git with mintty 3.7.6 but it persists.
I'm still curious what could be different about your setup.

@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2024

@Trass3r not sure, if it works in Windows Terminal but not VS Code then hopefully it'll get fixed when we get access to conpty v2 (#224488).

@Trass3r
Copy link
Author

Trass3r commented Dec 19, 2024

Ah good hint, it works in a separate Git Bash, but not when opening the git bash in Windows Terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug confirmation-pending *not-reproducible Issue cannot be reproduced by VS Code Team member as described windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

4 participants