-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed latest ConPTY implementation #490
Comments
I thought about doing this but I didn't really want to take on the potential instability and additional build complexity that comes with it. |
As an optional addition we could support it, maybe by adding options to point to the conhost binary. I'm not sure we would want to take on burden for maintaining extra build targets or something. |
I don't know whether that's still considered, but I think it could be useful. While currently new conpty/conhost is not available publicly, the Windows Terminal does embed a new one, and their build artifacts (but not the release package) currently does include So an adventurous user could use those, and for node-pty it could be an opportunity to test the integration with an out-of-tree conpty (at PATH maybe?) before it becomes available publicly (or maybe in-tree where conpty.dll and openconsole.exe are placed manually together with One main advantage I think a new conpty/conhost has is support for mouse (wheel?) events in console applications, which currently doesn't work at the vscode terminal. |
Microsoft ships the bleeding edge ConPTY client-side implementation with Windows Terminal, which includes features like mouse support. Only much later does it get pushed into Windows baseline which means node-pty doesn't get these features until then.
Do we want to pull these sources into node-pty?
Their code is MIT licensed.
Note: this also requires building a custom conhost binary
The text was updated successfully, but these errors were encountered: