Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 0.11.0-beta hangs on IConptyNative.connect) #532

Closed
starpit opened this issue Feb 24, 2022 · 1 comment
Closed

Windows 10 0.11.0-beta hangs on IConptyNative.connect) #532

starpit opened this issue Feb 24, 2022 · 1 comment
Labels
duplicate help wanted Issues identified as good community contribution opportunities

Comments

@starpit
Copy link

starpit commented Feb 24, 2022

Environment details

  • OS: Windows
  • OS version: 10
  • node-pty version: 0.11.0-beta17 and beta18

Issue description

We haven't had a problem with 0.10.0. With 0.11.0 betas on Windows, the conpty bits hang

    if (this._useConpty) {
console.error('######################### 9') // we see this
      const connect = (this._ptyNative as IConptyNative).connect(this._pty, commandLine, cwd, env, c => this._$onProcessExit(c));
      this._innerPid = connect.pid;
console.error('######################### 10') // we don't see this
    }

We get the first printf, but not the second. We get no printfs for _$onProcessExit. We are spawning this from the Electron main process, which hasn't been a problem (and still isn't a problem, on every other platform). I have seen #512 but that user saw the hang on exit, whereas we can't even get the connection established.

Fwiw, the spawned command line is powershell.exe "echo hi"

@Tyriar
Copy link
Member

Tyriar commented Dec 17, 2024

Closing as it could be an issue with an old version of Windows 10, but regardless we're moving towards shipping the conpty dll with node-pty #490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

2 participants