-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update grpc and genproto library to avoid panic in ttrpc #1000
Merged
katiewasnothere
merged 1 commit into
microsoft:master
from
katiewasnothere:fix_ttrpc_status_panic
Apr 13, 2021
Merged
Update grpc and genproto library to avoid panic in ttrpc #1000
katiewasnothere
merged 1 commit into
microsoft:master
from
katiewasnothere:fix_ttrpc_status_panic
Apr 13, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kathryn Baldauf <[email protected]>
dcantah
approved these changes
Apr 13, 2021
anmaxvl
approved these changes
Apr 13, 2021
anmaxvl
pushed a commit
to anmaxvl/hcsshim
that referenced
this pull request
Aug 19, 2021
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Sep 26, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
Nov 27, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle
added a commit
to TBBle/hcsshim
that referenced
this pull request
May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for containerd/ttrpc#62. However, this was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us. See also containerd/ttrpc#89, which documents that only google.golang.org/genproto needs to be locked. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in containerd/ttrpc#62 by following the same package versions used in upstream containerd (introduced here).
Signed-off-by: Kathryn Baldauf [email protected]