Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cmd.String() when logging binary_io command #978

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Mar 19, 2021

additionally clean up potential linter errors

Signed-off-by: Maksim An [email protected]

@anmaxvl anmaxvl requested a review from a team as a code owner March 19, 2021 20:28
@anmaxvl anmaxvl force-pushed the maksiman/binary-io-debug-cleanup branch from e869ce2 to 96f00fc Compare March 20, 2021 01:24
internal/cmd/io_binary.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides the one comment

@anmaxvl anmaxvl force-pushed the maksiman/binary-io-debug-cleanup branch from 96f00fc to 0ad8cf7 Compare March 23, 2021 20:53
additionally clean up potential linter errors

Signed-off-by: Maksim An <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants