-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix golangci linter issues #976
Conversation
* Remove unused mutex for the grpc service in ncproxy * Remove unneccessary os.Stat call that didn't even check the return value *facepalm* Signed-off-by: Daniel Canter <[email protected]>
This is one of a few PRs to get golangci happy with our repo before we swap over. #975 |
if os.Stat(diffVhdPath); err == nil { | ||
os.RemoveAll(diffVhdPath) | ||
} | ||
os.RemoveAll(diffVhdPath) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing the Stat
call, should we be checking the return value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't really even see a need for the stat call. If the file doesn't exist RemoveAll will just silently succeed anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
facepalm
Signed-off-by: Daniel Canter [email protected]