Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tar extraction issue where parent directories don't exist. #972

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

ambarve
Copy link
Contributor

@ambarve ambarve commented Mar 16, 2021

Extracting LCOW layers to vhd fails when a file shows up in the
tar list before the parent directory of that file shows up. This change fixes that by
always creating any non existing parent directories and then updating their permissions
later when actual directory entry shows up.

Signed-off-by: Amit Barve [email protected]

@ambarve ambarve requested a review from a team as a code owner March 16, 2021 20:40
Extracting LCOW layers to vhd fails when a file shows up in the
tar list before the parent directory of that file shows up. This change fixes that by
always creating any non existing parent directories and then updating their permissions
later when actual directory entry shows up.

Signed-off-by: Amit Barve <[email protected]>
@ambarve ambarve merged commit 7f22549 into microsoft:master Mar 16, 2021
ambarve added a commit to ambarve/hcsshim that referenced this pull request Apr 1, 2021
tar2ext layer expansion had a bug where during a tar expansion if a file showed up before
its parent directory then the expansion would fail with path not found error. This was
fixed in microsoft#972. This commit just a adds a test for that fix.
ambarve added a commit to ambarve/hcsshim that referenced this pull request Apr 1, 2021
tar2ext layer expansion had a bug where during a tar expansion if a file showed up before
its parent directory then the expansion would fail with path not found error. This was
fixed in microsoft#972. This commit just a adds a test for that fix.

Signed-off-by: Amit Barve <[email protected]>
ambarve added a commit to ambarve/hcsshim that referenced this pull request Apr 1, 2021
tar2ext layer expansion had a bug where during a tar expansion if a file showed up before
its parent directory then the expansion would fail with path not found error. This was
fixed in microsoft#972. This commit just a adds a test for that fix.

Signed-off-by: Amit Barve <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants