Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: go.mod: github/containerd/containerd v1.5.0-beta.4 #968

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Mar 12, 2021

No description provided.

@thaJeztah thaJeztah requested a review from a team as a code owner March 12, 2021 16:55
Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you update this branch as well?

@thaJeztah
Copy link
Contributor Author

Thanks for review; containerd v1.5.0-beta.4 was also released since I opened this PR; I'll rebase and update to that version as well (assuming that's ok with you); I'll ping when I've updated

@thaJeztah thaJeztah changed the title test: go.mod: github/containerd/containerd v1.5.0-beta.3 test: go.mod: github/containerd/containerd v1.5.0-beta.4 Mar 17, 2021
@thaJeztah
Copy link
Contributor Author

rebased, and updated to v1.5.0-beta.4; ptal 👍

Copy link
Contributor

@katiewasnothere katiewasnothere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again as well, merging. The out of date warning below is from me merging the other one.

@thaJeztah
Copy link
Contributor Author

The out of date warning below is from me merging the other one.

no worries, I was anticipating that (we tried using that option in the moby/moby repository, but it was too difficult to work with in an active repository 😞, so we disabled it again)

rebased 👍

@katiewasnothere
Copy link
Contributor

Yeah we may need to revisit enabling that option haha just waiting for the CI to finish and then I'll merge

@katiewasnothere katiewasnothere merged commit ae2494c into microsoft:master Mar 17, 2021
@thaJeztah thaJeztah deleted the bump_test_deps branch March 17, 2021 21:35
@thaJeztah
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants