-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: go.mod: github/containerd/containerd v1.5.0-beta.4 #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you update this branch as well?
Thanks for review; containerd v1.5.0-beta.4 was also released since I opened this PR; I'll rebase and update to that version as well (assuming that's ok with you); I'll ping when I've updated |
0a6a367
to
0da34e8
Compare
rebased, and updated to v1.5.0-beta.4; ptal 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again as well, merging. The out of date warning below is from me merging the other one.
Signed-off-by: Sebastiaan van Stijn <[email protected]>
8603fdd
to
e3bde0e
Compare
no worries, I was anticipating that (we tried using that option in the moby/moby repository, but it was too difficult to work with in an active repository 😞, so we disabled it again) rebased 👍 |
Yeah we may need to revisit enabling that option haha just waiting for the CI to finish and then I'll merge |
Thanks! |
This PR updates our internal ADO repo to the github commit [d9474d2](microsoft@d9474d2). Related work items: microsoft#964, microsoft#965, microsoft#966, microsoft#967, microsoft#968, microsoft#969, microsoft#970, microsoft#971, microsoft#972, microsoft#974, microsoft#975, microsoft#976, microsoft#977, microsoft#978, microsoft#979, microsoft#980, microsoft#981, microsoft#982, microsoft#983, microsoft#984, microsoft#987, microsoft#990, microsoft#991, microsoft#992, microsoft#993, microsoft#995, microsoft#996, microsoft#997, microsoft#1000
No description provided.