Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

panic: protobuf tag not enough fields in Status.state #62

Closed
eclipseo opened this issue Jul 25, 2020 · 13 comments
Closed

panic: protobuf tag not enough fields in Status.state #62

eclipseo opened this issue Jul 25, 2020 · 13 comments

Comments

@eclipseo
Copy link

Go 1.15 beta 1 , with github.com/gogo/protobuf 1.3.1
Not sure if I amdoung something wrong.

Testing    in: /builddir/build/BUILD/ttrpc-1.0.1/_build/src
         PATH: /builddir/build/BUILD/ttrpc-1.0.1/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/ttrpc-1.0.1/_build:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -ldflags "-X github.com/containerd/ttrpc/version=1.0.1 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
      testing: github.com/containerd/ttrpc
github.com/containerd/ttrpc
panic: protobuf tag not enough fields in Status.state: 
goroutine 54 [running]:
github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0x4000120a00)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x1238
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0x4000120a00, 0x4000f1a000, 0x4000f16002, 0xf, 0xf, 0xaaaacb74a848, 0x4000026000)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0xb50
github.com/gogo/protobuf/proto.makeUnmarshalMessagePtr.func1(0x4000f16002, 0x10, 0x10, 0x4000158420, 0x2, 0x7, 0x4000f87ae8, 0xaaaacb6ebb08, 0x4000f87bc0, 0x756ea1e68af79e)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:1826 +0xd0
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0x4000120960, 0x4000158420, 0x4000f16000, 0x11, 0x11, 0xc, 0x4000f87c48)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:175 +0x5f4
github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0x4000f0e040, 0xaaaacbbfdde0, 0x4000158420, 0x4000f16000, 0x11, 0x11, 0x4000f87c01, 0x0)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0x58
github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0x4000f23ce0, 0xaaaacbbfdde0, 0x4000158420, 0x0, 0x0)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/decode.go:424 +0x1c4
github.com/gogo/protobuf/proto.Unmarshal(0x4000f16000, 0x11, 0x11, 0xaaaacbbfdde0, 0x4000158420, 0x4000f022b8, 0x4000f87f68)
	/usr/share/gocode/src/github.com/gogo/protobuf/proto/decode.go:342 +0x110
github.com/containerd/ttrpc.(*Client).recv(0x4001008580, 0x4000158420, 0x4000f18000, 0x0, 0x0)
	/builddir/build/BUILD/ttrpc-1.0.1/_build/src/github.com/containerd/ttrpc/client.go:323 +0x13c
github.com/containerd/ttrpc.(*Client).run(0x4001008580)
	/builddir/build/BUILD/ttrpc-1.0.1/_build/src/github.com/containerd/ttrpc/client.go:273 +0x354
created by github.com/containerd/ttrpc.NewClient
	/builddir/build/BUILD/ttrpc-1.0.1/_build/src/github.com/containerd/ttrpc/client.go:92 +0x160
exit status 2
FAIL	github.com/containerd/ttrpc	0.514s
@eclipseo
Copy link
Author

eclipseo commented Aug 9, 2020

It seems gogo/protobuf is not compatible with APIv2 protobuf 1.4

gogo/protobuf#678

Since gogo/protobuf is looking for new maintainers, I don't expect this to be "fixable" soon. The best option would be to move to github.com/golang/protobuf.

@fgiudici
Copy link

fgiudici commented Sep 3, 2020

Looked a bit into this: ttrpc relies on gogo/protobuf and imports: google.golang.org/genproto/googleapis/rpc/status
https://github.com/containerd/ttrpc/blob/master/types.go#L22

googleapis are generated via golang protobuf, so newer versions of googleapis bring a different go file. The rcp/status package contains just one status.pb.go file, generated from
https://github.com/googleapis/googleapis/blob/master/google/rpc/status.proto

Here the commit updating the generated code when switching to the newer golang protobuf:
googleapis/go-genproto@8feb7f2#diff-98786b22033f064ef96637aa8531dbe9L32-L45
Note how the struct Status changed, in particular a new member state protoimpl.MessageState
(find it in the file googleapis/rpc/status/status.pb.go).

gogo/protobuf unmarshal code checks explicitly for the older Status struct members (e.g., look as an example at https://github.com/gogo/protobuf/blob/master/proto/table_unmarshal.go#L327 and googleapis/go-genproto@8feb7f2#diff-98786b22033f064ef96637aa8531dbe9L42).

gogo/protobuf unmashal code then panics as it is not able to recognize the newer state member brought in the code generated with the newer protobuf here: https://github.com/gogo/protobuf/blob/master/proto/table_unmarshal.go#L341


So, the question is: how will this be handled in the ttrpc package? As seems no one is going to jump on updating the gogo/protobuf, will the gogo/protobuf be dropped in favor of the newer golang/protobuf? It will be not a trivial change but waht could be the other options?

@katiewasnothere
Copy link

katiewasnothere commented Apr 9, 2021

Is there any update here? We're running into the same error in https://github.com/Microsoft/hcsshim

@brandond
Copy link

brandond commented Aug 20, 2021

We're running into the same issue when trying to update K3s to Kubernetes 1.22:

Unfortunately we can't work around this by downgrading our vendored grpc libraries to 1.27.0, as Kubernetes 1.22 now includes opentelemetry support which needs at least grpc 1.32.0.

With containerd itself updating the grpc versions in containerd/containerd#5613, it seems like the only thing left to do is dig in and fix ttrpc to drop the deprecated libraries.

@kzys
Copy link
Member

kzys commented Aug 20, 2021

Would #89 be a workaround? Ultimately we would need to do #67 though. Sorry, we need the opposite solution, which is migrating off from gogo.

@brandond
Copy link

brandond commented Aug 21, 2021

For the record, that workaround did work. It appears that pinning go-genproto to any commit before googleapis/go-genproto#366 was merged should resolve the issue. As noted above the gogo/protobuf code expects either legacy XXX_ fields, or fields with protobuf tags on them. It can't handle fields with neither (state/sizeCache/unknownFields).

klihub added a commit to klihub/nri that referenced this issue Sep 1, 2021
klihub added a commit to klihub/nri that referenced this issue Sep 7, 2021
TBBle added a commit to TBBle/hcsshim that referenced this issue Sep 26, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle added a commit to TBBle/hcsshim that referenced this issue Nov 27, 2021
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
@houstar
Copy link

houstar commented Dec 13, 2021

Is that looks the same problem?

panic: protobuf tag not enough fields in Empty.state:

goroutine 259 [running]:
github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0xc0002ae320)
        /root/go/pkg/mod/github.com/gogo/[email protected]/proto/table_unmarshal.go:341 +0x1897
github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc0002ae320, 0xc000accc90, 0x0, 0x0, 0x0, 0x40e0f8, 0x20)
        /root/go/pkg/mod/github.com/gogo/[email protected]/proto/table_unmarshal.go:138 +0xf65
github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0xc000bde2a0, 0x7fa7115b92d8, 0xc000accc90, 0x0, 0x0, 0x0, 0xc000accc01, 0x0)
        /root/go/pkg/mod/github.com/gogo/[email protected]/proto/table_unmarshal.go:63 +0x66
github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0xc0009891c8, 0x7fa7115b92d8, 0xc000accc90, 0x0, 0x0)
        /root/go/pkg/mod/github.com/gogo/[email protected]/proto/decode.go:424 +0x1f5
github.com/gogo/protobuf/proto.Unmarshal(0x0, 0x0, 0x0, 0x7fa7115b92d8, 0xc000accc90, 0xc000bf3d01, 0xc000f1e160)
        /root/go/pkg/mod/github.com/gogo/[email protected]/proto/decode.go:342 +0x15e
github.com/containerd/ttrpc.codec.Unmarshal(0x0, 0x0, 0x0, 0x1e5b020, 0xc000accc90, 0xc000ace5c0, 0x0)
        /root/go/pkg/mod/github.com/containerd/[email protected]/codec.go:39 +0xf2
github.com/containerd/ttrpc.(*Client).Call(0xc000aca680, 0x23fd128, 0xc00005c308, 0x216da10, 0x28, 0x2141bf8, 0xc, 0x1f8bfe0, 0xc000accc60, 0x1e5b020, ...)
        /root/go/pkg/mod/github.com/containerd/[email protected]/client.go:136 +0x38e
github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/disk/proto.(*extendedStatusClient).ExpandVolume(0xc000989440, 0x23fd128, 0xc00005c308, 0xc000accc60, 0x0, 0xc000aca680, 0xc00000f360)
        /root/go/src/github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/disk/proto/disk.pb.go:208 +0xbd
github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/disk.checkRundVolumeExpand(0xc000230a50, 0x0, 0x0, 0x0)
        /root/go/src/github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/disk/utils.go:1559 +0x2b2
github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/disk.(*nodeServer).NodeExpandVolume(0xc000bf2900, 0x23fd198, 0xc000acc750, 0xc000230a50, 0xc000bf2900, 0x1, 0xc000a809a8)
        /root/go/src/github.com/kubernetes-sigs/alibaba-cloud-csi-driver/pkg/disk/nodeserver.go:768 +0x19c
github.com/container-storage-interface/spec/lib/go/csi._Node_NodeExpandVolume_Handler.func1(0x23fd198, 0xc000acc750, 0x1f6c040, 0xc000230a50, 0x0, 0x203000, 0x7fa7111d0f70, 0x18)
        /root/go/pkg/mod/github.com/container-storage-interface/[email protected]/lib/go/csi/csi.pb.go:5420 +0x89
github.com/kubernetes-csi/drivers/pkg/csi-common.logGRPC(0x23fd198, 0xc000acc750, 0x1f6c040, 0xc000230a50, 0xc000f1e0e0, 0xc000a80990, 0xc000554b80, 0x646f86, 0x1f422e0, 0xc000acc750)
        /root/go/pkg/mod/github.com/kubernetes-csi/[email protected]/pkg/csi-common/utils.go:99 +0x164
github.com/container-storage-interface/spec/lib/go/csi._Node_NodeExpandVolume_Handler(0x1f642e0, 0xc000bf2900, 0x23fd198, 0xc000acc750, 0xc000bf3aa0, 0x2235048, 0x23fd198, 0xc000acc750, 0xc0004c0e00, 0xf4)
        /root/go/pkg/mod/github.com/container-storage-interface/[email protected]/lib/go/csi/csi.pb.go:5422 +0x150
google.golang.org/grpc.(*Server).processUnaryRPC(0xc000d21200, 0x2419e58, 0xc000e00d80, 0xc000c00c00, 0xc000ad0300, 0x375bd38, 0x0, 0x0, 0x0)
        /root/go/pkg/mod/google.golang.org/[email protected]/server.go:1024 +0x522
google.golang.org/grpc.(*Server).handleStream(0xc000d21200, 0x2419e58, 0xc000e00d80, 0xc000c00c00, 0x0)
        /root/go/pkg/mod/google.golang.org/[email protected]/server.go:1313 +0xd2c
google.golang.org/grpc.(*Server).serveStreams.func1.1(0xc000b00430, 0xc000d21200, 0x2419e58, 0xc000e00d80, 0xc000c00c00)
        /root/go/pkg/mod/google.golang.org/[email protected]/server.go:722 +0xab
created by google.golang.org/grpc.(*Server).serveStreams.func1
        /root/go/pkg/mod/google.golang.org/[email protected]/server.go:720 +0xa5

@l0rda
Copy link

l0rda commented Jan 20, 2022

Looks same:

Jan 20 18:51:06 docker.lan containerd[262654]: goroutine 441794 [running]:
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0xc0004886e0)
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x138a
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc0004886e0, {0xc0005dfec0}, {0xc00095c242, 0x66, 0x219})
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0x67
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.makeUnmarshalMessagePtr.func1({0xc00095c241, 0x5611aa893ee6, 0x5611abcc2d80}, {0x300000002}, 0xc000788b60)
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:1826 +0x15a
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc0004885a0, {0x5611abb63660}, {0xc00095c240, 0xc0005d1da0, 0x5611aa8618c7})
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:175 +0x36d
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0xc0003ccde0, {0x5611abcf1d00, 0xc0003ccda0}, {0xc00095c240, 0x68, 0x21b})
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0xd0
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0xc0002a5e18, {0x5611abcf1d00, 0xc0003ccda0})
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/decode.go:424 +0x153
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/gogo/protobuf/proto.Unmarshal({0xc00095c240, 0x68, 0x21b}, {0x5611abcf1d00, 0xc0003ccda0})
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/decode.go:342 +0xef
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/containerd/ttrpc.(*Client).recv(0xc00013d3a0, 0xc0001298c0, 0xc00045b441)
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/client.go:378 +0xfe
Jan 20 18:51:06 docker.lan containerd[262654]: github.com/containerd/ttrpc.(*Client).run.func2()
Jan 20 18:51:06 docker.lan containerd[262654]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/client.go:318 +0x257
Jan 20 18:51:06 docker.lan containerd[262654]: created by github.com/containerd/ttrpc.(*Client).run```

@brandond
Copy link

Yes, these are all the same problem. It's pretty well defined at this point. Just posting stack traces without any info on where or when you're seeing them doesn't really add much to the conversation though.

@l0rda
Copy link

l0rda commented Jan 20, 2022

Yes, these are all the same problem. It's pretty well defined at this point. Just posting stack traces without any info on where or when you're seeing them doesn't really add much to the conversation though.

What info is required?

$ docker -v
Docker version 20.10.11, build dea9396
$ containerd -v
containerd github.com/containerd/containerd 1.4.4 05f951a3781f4f2c1911b05e61c160e9c30eaa8e
$ uname -a
Linux docker.lan 5.10.83-5.ph4-esx #1-photon SMP Tue Jan 4 02:55:19 UTC 2022 x86_64 GNU/Linux

@MikeVL
Copy link

MikeVL commented Feb 5, 2022

Same problem with Kubernetes v1.23.3

$ containerd -v
containerd github.com/containerd/containerd 1.4.4 05f951a3781f4f2c1911b05e61c160e9c30eaa8e

$ runc -v
runc version 1.0.0-rc93
commit: 14faf1c20948688a48edb9b41367ab07ac11ca91
spec: 1.0.2-dev
go: go1.17.2
libseccomp: 2.5.0

$ uname -a
Linux kube-node-4 5.10.93-3.ph4-esx #1-photon SMP Thu Jan 27 20:35:39 UTC 2022 x86_64 GNU/Linux
Feb 05 22:25:06 kube-node-4 containerd[18975]: panic: protobuf tag not enough fields in Status.state:
Feb 05 22:25:06 kube-node-4 containerd[18975]: goroutine 75 [running]:
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.(*unmarshalInfo).computeUnmarshalInfo(0xc0000b0140)
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:341 +0x138a
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc0000b0140, {0xc00019e1e0}, {0xc0001e2002, 0x24, 0x268})
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:138 +0x67
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.makeUnmarshalMessagePtr.func1({0xc0001e2001, 0x55000000000a, 0xc000184d00}, {0x300000002}, 0x7f9538b1e7e0)
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:1826 +0x15a
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.(*unmarshalInfo).unmarshal(0xc0000b0000, {0x55b91f384660}, {0xc0001e2000, 0xc0005bfda0, 0x55b91e0828c7})
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:175 +0x36d
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.(*InternalMessageInfo).Unmarshal(0xc000366000, {0x55b91f512d00, 0xc00035a520}, {0xc0001e2000, 0x26, 0x26a})
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/table_unmarshal.go:63 +0xd0
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.(*Buffer).Unmarshal(0xc00072be18, {0x55b91f512d00, 0xc00035a520})
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/decode.go:424 +0x153
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/gogo/protobuf/proto.Unmarshal({0xc0001e2000, 0x26, 0x26a}, {0x55b91f512d00, 0xc00035a520})
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/gogo/protobuf/proto/decode.go:342 +0xef
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/containerd/ttrpc.(*Client).recv(0xc000366140, 0x746c6f622e31, 0x61746e6f632e6f69)
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/client.go:378 +0xfe
Feb 05 22:25:06 kube-node-4 containerd[18975]: github.com/containerd/ttrpc.(*Client).run.func2()
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/client.go:318 +0x257
Feb 05 22:25:06 kube-node-4 containerd[18975]: created by github.com/containerd/ttrpc.(*Client).run
Feb 05 22:25:06 kube-node-4 containerd[18975]:         /usr/src/photon/BUILD/containerd-1.4.4/src/github.com/containerd/containerd/vendor/github.com/containerd/ttrpc/client.go:286 +0x185

@kzys
Copy link
Member

kzys commented Feb 21, 2022

The main branch no longer have gogo/protobuf and can be used with latest protobuf packages from Google.

Upgrade in containerd is still in progress. The tracking ticket is containerd/containerd#6564.

@kzys
Copy link
Member

kzys commented Apr 25, 2022

Resolving since both containerd/ttrpc and containerd/containerd don't directly consume gogo/protobuf anymore!

@kzys kzys closed this as completed Apr 25, 2022
TBBle added a commit to TBBle/hcsshim that referenced this issue May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
TBBle added a commit to TBBle/hcsshim that referenced this issue May 4, 2022
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
ckatsak added a commit to ckatsak/fcctrdtestcli that referenced this issue Nov 1, 2022
winkingturtle-vmw added a commit to cloudfoundry/guardian that referenced this issue Feb 14, 2023
until containerd is using new versions of ttrpc

Context: containerd/ttrpc#62
geofffranks pushed a commit to cloudfoundry/guardian that referenced this issue Feb 14, 2023
until containerd is using new versions of ttrpc

Context: containerd/ttrpc#62
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants