Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects #5129

Closed
33 of 36 tasks
ryanbodrug-microsoft opened this issue Jul 21, 2020 · 3 comments
Closed
33 of 36 tasks
Assignees
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-Quality Stability, Performance, Etc.
Milestone

Comments

@ryanbodrug-microsoft
Copy link
Contributor

ryanbodrug-microsoft commented Jul 21, 2020

Summary of the new feature/enhancement

  1. Enable Static analysis on each of the
`csproj files.  Project -> Properties -> CodeAnalysis -> Microsoft.CodeAnalysis.FxCopAnalyzers `
  1. Set warnings as errors on each project
  2. Fix any errors due to static analysis
  3. Validate consistent behavior by testing locally.
  4. Ensure unit tests pass.

Proposed technical implementation details (optional)

Fix the following projects:

  • FancyZonesEditor.csproj <- blocked due to multi-mon improvements
  • win-app-driver.csproj
  • Telemetry.csproj <- [FxCop] Telemetry.csproj #6642, was reverted Farm swaps this file, will fail if we do this how everything currently is. The change honestly isn't really that massive

Done

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 21, 2020
@ryanbodrug-microsoft ryanbodrug-microsoft self-assigned this Jul 21, 2020
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 22, 2020
@ryanbodrug-microsoft ryanbodrug-microsoft added this to the InVEST-2008 milestone Aug 10, 2020
@ryanbodrug-microsoft ryanbodrug-microsoft changed the title Enable Static analysis on Launcher Plugings Enable Static analysis (FxCopAnalyzers) on C# Projects Aug 18, 2020
@ryanbodrug-microsoft
Copy link
Contributor Author

@crutkas I've updated the title and description to include all csproj files that need static analysis. Because this is expanding the scope beyond the launcher plugins I will probably remove the InVEST milestone. What do you think?

@crutkas
Copy link
Member

crutkas commented Aug 18, 2020

I'm good with that

@crutkas crutkas changed the title Enable Static analysis (FxCopAnalyzers) on C# Projects [Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects Aug 18, 2020
@crutkas crutkas added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-Quality Stability, Performance, Etc. labels Aug 18, 2020
@crutkas crutkas pinned this issue Aug 21, 2020
@crutkas crutkas mentioned this issue Aug 27, 2020
5 tasks
@crutkas crutkas mentioned this issue Sep 16, 2020
5 tasks
@crutkas
Copy link
Member

crutkas commented Nov 17, 2020

I'm going to close this out and create a new issue for a wrapper issue with StyleCop and FxCop. Few projects need to be touched

@crutkas crutkas closed this as completed Nov 17, 2020
@crutkas crutkas removed the Status-In progress This issue or work-item is under development label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-Quality Stability, Performance, Etc.
Projects
None yet
Development

No branches or pull requests

2 participants