Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fxcop] Settings UI unit tests #6987

Merged

Conversation

lmawarid
Copy link
Member

@lmawarid lmawarid commented Oct 2, 2020

Summary of the Pull Request

Adding FxCop to the Microsoft.PowerToys.Settings.UI.UnitTests.csproj project, and fixing the resulting warnings and errors.

PR Checklist

  • Applies to [Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects #5129
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
    image
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

Changes made to fix the warnings and errors include: changing method naming conventions, adding message for deprecated methods, marking non-instance-accessing methods as static, removing unused code, replacing usage of Count() method for Lists with the more efficient Count property, renaming unused arguments, validating arguments for public methods.

Validation Steps Performed

Check there are no fxcop warnings and the related tests pass.

@lmawarid lmawarid marked this pull request as ready for review October 3, 2020 00:20
@arjunbalgovind arjunbalgovind requested a review from a team October 5, 2020 17:20
Copy link
Contributor

@ryanbodrug-microsoft ryanbodrug-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work

@lmawarid lmawarid merged commit a2fce22 into microsoft:master Oct 6, 2020
@lmawarid lmawarid deleted the dev/lumawari/settings-unittest-fxcop branch October 6, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants