[fxcop] Settings UI unit tests #6987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AssertHotkeySettings
36 tasks
ryanbodrug-microsoft
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adding FxCop to the Microsoft.PowerToys.Settings.UI.UnitTests.csproj project, and fixing the resulting warnings and errors.
PR Checklist
Info on Pull Request
Changes made to fix the warnings and errors include: changing method naming conventions, adding message for deprecated methods, marking non-instance-accessing methods as static, removing unused code, replacing usage of Count() method for Lists with the more efficient Count property, renaming unused arguments, validating arguments for public methods.
Validation Steps Performed
Check there are no fxcop warnings and the related tests pass.