Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FxCop] FancyZone Editor part 1 of many #6898

Closed
wants to merge 1 commit into from

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Sep 29, 2020

Summary of the Pull Request

Doing it gradually. I'm slowly upgrading stuff as this is a high traffic zone for the next few iterations. This is knocking out a few of violations

PR Checklist

  • Applies to [Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects #5129
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@enricogior
Copy link
Contributor

@crutkas
this would generate too many conflicts with #6562

@crutkas
Copy link
Member Author

crutkas commented Sep 29, 2020

Ok. I can close and redo this. Was trying to minimize the conflicts with small check ins.

@crutkas crutkas closed this Sep 29, 2020
@crutkas crutkas deleted the dev/crutkas/fxCopFancyZonesEditor branch October 5, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants