-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FancyZones] Editor multi monitor support #6562
Conversation
Awesome work. Thanks |
src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
src/modules/fancyzones/editor/FancyZonesEditor/ViewModels/MonitorViewModel.cs
Outdated
Show resolved
Hide resolved
Great idea and work. 👍 Just two questions:
|
Thanks! |
85d782a
to
289d61d
Compare
If
As @SeraphimaZ said, nothing changes compared to the current behavior. If you want to edit the layout for a VD, first switch to that VD and then open the FZ editor. |
@@ -616,7 +615,7 @@ void FancyZones::ToggleEditor() noexcept | |||
} | |||
else | |||
{ | |||
zoneWindow = m_workAreaHandler.GetWorkArea(m_currentDesktopId, monitor); | |||
zoneWindow = m_workAreaHandler.GetWorkArea(m_currentDesktopId, targetMonitor); | |||
} | |||
|
|||
if (!zoneWindow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename zoneWindow
to workArea
src/modules/fancyzones/editor/FancyZonesEditor/Models/Settings.cs
Outdated
Show resolved
Hide resolved
ffac0ae
to
78c2e1a
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
can't wait to try this out :) |
src/modules/fancyzones/editor/FancyZonesEditor/Utils/WorkAreaData.cs
Outdated
Show resolved
Hide resolved
9d22374
to
48937c3
Compare
…sEditorIO.cs Co-authored-by: Enrico Giordani <[email protected]>
…sEditorIO.cs Co-authored-by: Enrico Giordani <[email protected]>
dcc5419
to
e762e26
Compare
Summary of the Pull Request
Multi-monitor support.
PR Checklist
Info on Pull Request
Layout and layout settings could be selected for each monitor. Any change would be saved after clicking
Apply
. For now, theApply
button doesn't close the editor window.On the active monitor selection, layout and settings are shown accordingly to the monitor (except switching
Templates
andCustom
tabs)Displays are presented with their relative dimensions.
Validation Steps Performed
Use the editor with different desktops configurations.
Verify:
Zone count
,Show space around zones
,Space around zones
) are saved individually for each desktop and those values are changed on the desktop switch in the editor.