[FancyZones] Editor multi monitor support #6562

SeraphimaZykova · 2020-09-11T11:44:37Z

Summary of the Pull Request

Multi-monitor support.

PR Checklist

Applies to [FZ Editor] multi monitor support #6435
CLA signed. If not, go over here and sign the CLA
Tests added/passed

Info on Pull Request

Layout and layout settings could be selected for each monitor. Any change would be saved after clicking Apply. For now, the Apply button doesn't close the editor window.
On the active monitor selection, layout and settings are shown accordingly to the monitor (except switching Templates and Custom tabs)

Displays are presented with their relative dimensions.

Validation Steps Performed

Use the editor with different desktops configurations.
Verify:

settings were saved properly for each desktop.
zones are placed properly for each desktop
- in the editor preview
- while editing
- after being applied
grid and canvas editors don't crash.
template settings (Zone count, Show space around zones, Space around zones) are saved individually for each desktop and those values are changed on the desktop switch in the editor.

Aaron-Junker · 2020-09-11T11:49:47Z

Awesome work. Thanks

src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml.cs

src/modules/fancyzones/editor/FancyZonesEditor/ViewModels/MonitorViewModel.cs

htcfreek · 2020-09-18T06:53:10Z

Great idea and work. 👍

Just two questions:

I am not sure if it is possible to span zones over multiple monitors at the moment. But if so, van the user also select both monitors at the same time?
How does it behave with Virtual Desktop?

SeraphimaZykova · 2020-09-18T18:01:18Z

I am not sure if it is possible to span zones over multiple monitors at the moment. But if so, van the user also select both monitors at the same time?

How does it behave with Virtual Desktop?

Thanks!
In the current implementation, it's not possible to select both monitors at the same time. Spanning zones overs monitors is possible if you use the Allow zones to span across monitors option.
Regarding VD, the temp file with layouts data using by the editor contains layouts only for active VD. This way you can open the editor on any VD and see corresponding data.

enricogior · 2020-09-21T11:59:30Z

@htcfreek

I am not sure if it is possible to span zones over multiple monitors at the moment. But if so, van the user also select both monitors at the same time?

If Allow zones to span across monitors is on, only one monitor will be available and it will allow to create zones that span across monitors.
We will not implement a feature that will allow to select multiple monitors in the editor.

How does it behave with Virtual Desktop?

As @SeraphimaZ said, nothing changes compared to the current behavior. If you want to edit the layout for a VD, first switch to that VD and then open the FZ editor.

src/modules/fancyzones/lib/FancyZones.cpp

enricogior · 2020-09-23T17:27:49Z

src/modules/fancyzones/lib/FancyZones.cpp

@@ -616,7 +615,7 @@ void FancyZones::ToggleEditor() noexcept
    }
    else
    {
-        zoneWindow = m_workAreaHandler.GetWorkArea(m_currentDesktopId, monitor);
+        zoneWindow = m_workAreaHandler.GetWorkArea(m_currentDesktopId, targetMonitor);
    }

    if (!zoneWindow)


Let's rename zoneWindow to workArea

src/modules/fancyzones/editor/FancyZonesEditor/Models/Settings.cs

crutkas · 2020-10-07T18:10:55Z

/azp run

azure-pipelines · 2020-10-07T18:11:22Z

Azure Pipelines successfully started running 1 pipeline(s).

crutkas · 2020-10-09T21:29:31Z

can't wait to try this out :)

src/modules/fancyzones/editor/FancyZonesEditor/Utils/WorkAreaData.cs

…sEditorIO.cs Co-authored-by: Enrico Giordani <[email protected]>

enricogior changed the title ~~[FancyZones] Editor 2.0~~ [FancyZones] Editor multi monitor support Sep 11, 2020

enricogior added the FancyZones-Editor Issue revolving the FancyZone Editor label Sep 11, 2020

SeraphimaZykova marked this pull request as draft September 11, 2020 12:14

enricogior reviewed Sep 15, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/MainWindow.xaml.cs Outdated Show resolved Hide resolved

enricogior reviewed Sep 15, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/ViewModels/MonitorViewModel.cs Outdated Show resolved Hide resolved

SeraphimaZykova force-pushed the fz_editor branch from 85d782a to 289d61d Compare September 21, 2020 06:11

enricogior reviewed Sep 23, 2020

View reviewed changes

src/modules/fancyzones/lib/FancyZones.cpp Outdated Show resolved Hide resolved

enricogior reviewed Sep 23, 2020

View reviewed changes

src/modules/fancyzones/lib/FancyZones.cpp Outdated Show resolved Hide resolved

enricogior reviewed Sep 23, 2020

View reviewed changes

This was referenced Sep 29, 2020

Multi monitor support #6890

Closed

[FxCop] FancyZone Editor part 1 of many #6898

Closed

crutkas mentioned this pull request Sep 29, 2020

[FancyZones Editor] Fluent UX and theming support #6899

Closed

1 task

enricogior reviewed Oct 1, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/Models/Settings.cs Outdated Show resolved Hide resolved

enricogior mentioned this pull request Oct 2, 2020

Fancy Zones: Screen Chooser Menu for Zone Editor #1945

Closed

SeraphimaZykova force-pushed the fz_editor branch 2 times, most recently from ffac0ae to 78c2e1a Compare October 7, 2020 10:03

enricogior mentioned this pull request Oct 12, 2020

FancyZones feature for dual or more monitor users #7216

Closed

This was referenced Oct 12, 2020

Delete this issue please? #7237

Closed

[FancyZones] - Editor v2 #1032

Closed

enricogior reviewed Oct 13, 2020

View reviewed changes

src/modules/fancyzones/editor/FancyZonesEditor/Utils/WorkAreaData.cs Outdated Show resolved Hide resolved

SeraphimaZykova force-pushed the fz_editor branch from 9d22374 to 48937c3 Compare October 15, 2020 14:51

SeraphimaZykova marked this pull request as ready for review October 15, 2020 14:52

SeraphimaZykova requested a review from ivan100sic October 15, 2020 14:52

SeraphimaZykova and others added 24 commits November 16, 2020 20:02

report if monitor id not found

91b3a51

show work area coordinates in canvas layouts

60255f1

scaling canvas hardcoded values

744f16d

don't show close button with single monitor

14ea52a

use current work area with SpanZonesAcrossMonitors

7a7336b

switch tab

8585e23

misspelling

e0fd58f

merge conflicts fix

3a4a13d

Update src/modules/fancyzones/editor/FancyZonesEditor/Utils/FancyZone…

006d4e6

…sEditorIO.cs Co-authored-by: Enrico Giordani <[email protected]>

Update src/modules/fancyzones/editor/FancyZonesEditor/Utils/FancyZone…

663a128

…sEditorIO.cs Co-authored-by: Enrico Giordani <[email protected]>

refactoring

e8b4c97

refactoring

6befa1e

replaced MonitorInfoUtils with Screen

b75f499

per monitor awareness

1660529

manifest fix

5725966

Monitor detection logic

6263544

cherry-pick conflict fix

7104e93

refactoring

d889cbf

refactoring

ac92574

scale canvas zone position

1547e64

merge conflicts fix

a483f42

address PR comments: added localizable strings to resx

55d5377

address PR comments: commented non-localizable strings

b54c08c

parse device id unit tests

e762e26

SeraphimaZykova force-pushed the fz_editor branch from dcc5419 to e762e26 Compare November 17, 2020 07:40

enricogior approved these changes Nov 17, 2020

View reviewed changes

SeraphimaZykova merged commit b8e5ccf into microsoft:master Nov 17, 2020

SeraphimaZykova deleted the fz_editor branch November 17, 2020 08:38

ivan100sic mentioned this pull request Nov 18, 2020

[FZ Editor] Displaying the monitors layout #8104

Open

ivan100sic mentioned this pull request Jan 6, 2021

[FZ Editor] Crash while adding zones #8895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FancyZones] Editor multi monitor support #6562

[FancyZones] Editor multi monitor support #6562

SeraphimaZykova commented Sep 11, 2020 •

edited

Loading

Aaron-Junker commented Sep 11, 2020

htcfreek commented Sep 18, 2020 •

edited

Loading

SeraphimaZykova commented Sep 18, 2020

enricogior commented Sep 21, 2020

enricogior Sep 23, 2020

crutkas commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

crutkas commented Oct 9, 2020

[FancyZones] Editor multi monitor support #6562

[FancyZones] Editor multi monitor support #6562

Conversation

SeraphimaZykova commented Sep 11, 2020 • edited Loading

Summary of the Pull Request

PR Checklist

Info on Pull Request

Validation Steps Performed

Aaron-Junker commented Sep 11, 2020

htcfreek commented Sep 18, 2020 • edited Loading

SeraphimaZykova commented Sep 18, 2020

enricogior commented Sep 21, 2020

enricogior Sep 23, 2020

Choose a reason for hiding this comment

crutkas commented Oct 7, 2020

azure-pipelines bot commented Oct 7, 2020

crutkas commented Oct 9, 2020

SeraphimaZykova commented Sep 11, 2020 •

edited

Loading

htcfreek commented Sep 18, 2020 •

edited

Loading