Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FancyZones Editor] Fluent UX and theming support #6899

Closed
wants to merge 14 commits into from

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Sep 29, 2020

Summary of the Pull Request

This PR contains the following changes:

  • Support for light, dark and high contrast themes.
  • All controls and windows are styled to look (very) similar to WinUI and following Fluent Design UX guidelines (using ModernWPF for the style sheets).
  • Redesigned FZ editor layout.
  • Moving brushes and styles to dedicated ResourceDictionaries instead of inline in various pages.
  • Using updated AccentColor brushes so everything updates immediately when changing AccentColor.
  • Canvas layouts itemscontrol is now scrollable.
  • Accessibility improvements (due to high contrast and better layout for keyboard).

And overall, could be a nice basis to further ideate on solutions for some outstanding issues.

This PR should only be merged after #6562.

FZ darktheme

Layout selection screen
image

Dialogs
image

** High contrast**
image

PR Checklist

@htcfreek
Copy link
Collaborator

htcfreek commented Sep 29, 2020

@niels9001
Wow. Great work. I like it.

One question: How does the 'custom' section looks? (Asking because of #2207.)

@crutkas
Copy link
Member

crutkas commented Sep 29, 2020

how bad is this and #6562 going to conflict?

@niels9001
Copy link
Contributor Author

how bad is this and #6562 going to conflict?

I don't think there will be any major conflicts, since this PR touches mostly XAML files. Might be good to wait for #6562 to be merged - I think it's the new screen selection UI in the MainWindow that requires some work to get in.

@niels9001 niels9001 added the FancyZones-Editor Issue revolving the FancyZone Editor label Sep 29, 2020
@niels9001
Copy link
Contributor Author

@niels9001
Wow. Great work. I like it.

One question: How does the 'custom' section looks? (Asking because of #2207.)

image

Same behavior.

I believe we need to rethink the current tabs structure and how to create new layouts. I'll open a new issue to discuss that, since it's maybe not entirely in scope for this PR.

@htcfreek
Copy link
Collaborator

@niels9001
Wow. Great work. I like it.

One question: How does the 'custom' section looks? (Asking because of #2207.)

image

Same behavior.

I believe we need to rethink the current tabs structure and how to create new layouts. I'll open a new issue to discuss that, since it's maybe not entirely in scope for this PR.

Do we really need a new issue? We have issue #2207.

@enricogior
Copy link
Contributor

#6562 should be merged first, since it brings functional changes that we don't want to test in a merge with UI changes.

@htcfreek
Copy link
Collaborator

@niels9001
Wow. Great work. I like it.

One question: How does the 'custom' section looks? (Asking because of #2207.)

image

Same behavior.

I believe we need to rethink the current tabs structure and how to create new layouts. I'll open a new issue to discuss that, since it's maybe not entirely in scope for this PR.

Do we really need a new issue? We have issue #2207.

@niels9001
FYI, please look at #2208 too.

@enricogior
Copy link
Contributor

enricogior commented Sep 30, 2020

@niels9001
to have a consistent UI and show the proper available commands on the right panel, we should remove the custom tab, have just one tab that has all the layouts and distinguishes between grid layouts and canvas layouts.
For example, currently we don't support "Space around zone" for canvas layout, while we do for custom grid layouts (even if currently there is no UI for that).
Let us complete #6562 and then we can tackle this properly.

@niels9001
Copy link
Contributor Author

@enricogior Totally agree.

@htcfreek I have added my thoughts and some concepts in the Editor v2 topic. I think this would solve a lot of outstanding issues like the ones you mentioned. Some open questions pending.

#1032 (comment)

@niels9001 niels9001 marked this pull request as ready for review October 6, 2020 19:10
@crutkas
Copy link
Member

crutkas commented Oct 7, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crutkas
Copy link
Member

crutkas commented Oct 9, 2020

can we shift this into a draft PR so we don't accidently merge it in?

@niels9001 niels9001 marked this pull request as draft October 9, 2020 22:58
@enricogior
Copy link
Contributor

enricogior commented Nov 17, 2020

@niels9001
we merged #6562 for multi monitor support.
The next two work items are:

  • porting FZ Editor to .NET Core
  • merging this PR

Which one should we do first?
Consider that the two work items are not targeting 0.27 since we want freeze the code for 0.27 on Friday and it would take more time to test these changes.

@niels9001
Copy link
Contributor Author

@enricogior I think I'll close this PR and start a new branch based on master. Too many changes, but should be straightforward copy-and-pasting of e.g. brushes. I can finish this in the next week or so, so maybe better to wait for 0.28 for this work item?

@niels9001
Copy link
Contributor Author

I'm not sure if .NET Core would touch the UI / XAML at all? So we can work on it simultaneously?

@enricogior
Copy link
Contributor

@niels9001

better to wait for 0.28 for this work item?

Sure, it won't be in 0.27 for sure, not enough time to do it and test for 0.27.

I'm not sure if .NET Core would touch the UI / XAML at all? So we can work on it simultaneously?

I would assume it should not. We will start on the .NET Core migration, late this week or earlier next week. We will commit to master sometime next week.

@niels9001
Copy link
Contributor Author

Closing this in favor of: #8148

@niels9001 niels9001 closed this Nov 19, 2020
@niels9001 niels9001 deleted the users/niels9001/fzeditor-darkmode branch December 2, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys FancyZones-Editor Issue revolving the FancyZone Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants