Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fxcop] Settings UI library (part 4) - project/namespace renames #7403

Merged
merged 5 commits into from
Oct 22, 2020

Conversation

lmawarid
Copy link
Member

@lmawarid lmawarid commented Oct 20, 2020

Summary of the Pull Request

The final part of the effort to enable FxCop on the Settings project, involves renaming namespaces and projects to address CA1716.

PR Checklist

Info on Pull Request

  • Rename Microsoft.PowerToys.Settings.UI.Lib project to Microsoft.PowerToys.Settings.UI.Library (including associated namespaces and directories)
  • Rename Microsoft.PowerToys.Settings.UI.Interface to Microsoft.PowerToys.Settings.UI.Interfaces (namespace and directory)
  • Add FxCop to project file

Also includes some minor fixes that I might have missed out from the last PR.

Validation Steps Performed

Ensure the Library unit tests pass on Debug & Release mode, and manually validate settings functionality for Debug & Release builds.

@lmawarid lmawarid force-pushed the dev/lumawari/settings-lib-fxcop-4 branch from 940ac7e to 1e2b569 Compare October 21, 2020 21:51
@lmawarid lmawarid marked this pull request as ready for review October 21, 2020 22:50
@lmawarid lmawarid requested a review from a team October 21, 2020 22:52
Copy link
Contributor

@ryanbodrug-microsoft ryanbodrug-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmawarid lmawarid merged commit f92bd6f into microsoft:master Oct 22, 2020
@lmawarid lmawarid deleted the dev/lumawari/settings-lib-fxcop-4 branch October 22, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants