FxCopAnalyzer fixes for Wox.Test

[avneet-kr]

Summary of the Pull Request

This PR includes fixes for FxCop errors for Wox.Test

PR Checklist

• Applies to [Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects #5129
• CLA signed. If not, go over here and sign the CLA
• Tests added/passed
• Requires documentation to be updated
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

• Enabled FxCopAnalyzer for Wox.Test
• Added InvarientCulture info (CA1305: Specify IFormatProvider)
• Removed underscore from method names (CA1707: Identifiers should not contain underscores)
• Marked members as static (CA1822: Mark members as static)
• Removed initialization for DummyTestClass::IsFunctionCalled (CA1805: Do not initialize unnecessarily)
• Replaced Count with Any (CA1827: Do not use Count/LongCount when Any can be used)
• Changed WoxTest::DummyTestClass to private (CA1034: Nested types should not be visible)
• Suppressed warnings for uninstantiated internal classes used as TestFixtures (CA1812: Avoid uninstantiated internal classes)
  • Warnings were suppressed per this issue- CA1812 does not respect NUnit attributes dotnet/roslyn-analyzers#1830

Validation Steps Performed

All changes were validated by building and running unit tests

[avneet-kr]

PR has been updated to address comments:

• Changed InvariantCulture to Ordinal where appropriate
• Added suppression message for CA1812 in GlobalSuppressions.cs and removed inline supression messages (CA1812: Avoid uninstantiated internal classes)
• Updated justification for CA1812 in GlobalSuppressions.cs (Avoid uninstantiated internal classes)

[avneet-kr]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).