Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FxCop] Markdown preview pane unit tests #6758

Merged
merged 1 commit into from
Sep 22, 2020
Merged

[FxCop] Markdown preview pane unit tests #6758

merged 1 commit into from
Sep 22, 2020
+18 −12

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Sep 21, 2020 •
edited
Loading

Summary of the Pull Request

image

PR Checklist

  • Applies to [Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects #5129
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@crutkas crutkas requested a review from a team September 21, 2020 22:31
@crutkas crutkas mentioned this pull request Sep 21, 2020
Closed
36 tasks
ryanbodrug-microsoft
ryanbodrug-microsoft approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@ryanbodrug-microsoft ryanbodrug-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crutkas crutkas merged commit c1e9f2d into master Sep 22, 2020
@crutkas crutkas deleted the dev/crutkas/fxCopUnitTestMarkdown branch September 22, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbodrug-microsoft ryanbodrug-microsoft ryanbodrug-microsoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crutkas @ryanbodrug-microsoft