Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FxCop] Svg preview handler #6647

Merged
merged 2 commits into from
Sep 16, 2020
Merged

[FxCop] Svg preview handler #6647

merged 2 commits into from
Sep 16, 2020

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Sep 15, 2020

Summary of the Pull Request

Getting SVG handler working. Note due to namespace and object collision, renamed namespace to more holistic naming matching what we did on the markdown PR

image

PR Checklist

  • Applies to [Chore] Enable Static analysis (FxCopAnalyzers) on C# Projects #5129
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@crutkas crutkas changed the title fxcop for Svg preview handler [FxCop] Svg preview handler Sep 16, 2020
@crutkas crutkas merged commit 13fd6bd into master Sep 16, 2020
@crutkas crutkas deleted the dev/crutkas/fxCopSvgPreview branch September 16, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants