Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kubeadm-windows.md #14644

Closed
wants to merge 497 commits into from
Closed

Create kubeadm-windows.md #14644

wants to merge 497 commits into from

Conversation

grcusanz
Copy link

This is a placeholder for the doc that will describe specifics on how to use kubeadm with windows worker nodes.

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Remember to delete this note before submitting your pull request.

For pull requests on 1.15 Features: set Milestone to 1.15 and Base Branch to dev-1.15

For pull requests on Chinese localization, set Base Branch to release-1.14

For pull requests on Korean Localization: set Base Branch to dev-1.14-ko.<latest team milestone>

If you need Help on editing and submitting pull requests, visit:
https://kubernetes.io/docs/contribute/start/#improve-existing-content.

If you need Help on choosing which branch to use, visit:
https://kubernetes.io/docs/contribute/start#choose-which-git-branch-to-use.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

yzhong52 and others added 30 commits April 25, 2019 04:12
This seems like one of the key sections of the page users are likely to want to come directly to and matches the setup of some existing pages such as https://kubernetes.io/docs/concepts/workloads/controllers/jobs-run-to-completion/#advanced-usage
I thought this organization would give the users a better idea of what method to select based on the OS they use. 

Initially, I was a wee bit confused when I saw how to Install kubectl binary with curl on the Mac OS and then another section on how to install Kubectl on the Mac OS.

Now, I moved the content under the $subject to the respective OS section. 

P.S: I am still in the process of testing out the steps. :)
* Delete all pods matching the egrep pattern

* replace egrep with awk to delete pods by a pattern

* Update content/en/docs/reference/kubectl/cheatsheet.md

Co-Authored-By: ismailyenigul <[email protected]>
The doc has been migrated from the steering repo to the community repo:
https://git.k8s.io/community/values.md
…tes#14030)

* Translate declarative config for Bahasa Indonesia

* Fix typos and untranslated sentences from previous commit for declarative-config for Bahasa Indonesia

* Add _index.md to object-management-kubectl translations for Bahasa Indonesia
* How You Can Help Localize Kubernetes Docs

Minor edits

Minor edits

Publish for 25 Apr

One typo

* Update 2019-04-25-latest-on-localization.md

* Update and rename 2019-04-25-latest-on-localization.md to 2019-04-26-latest-on-localization.md
* interactive tutorial

* Translation
* Install Minikube

* Translation
fixed indentation for kubectl config view
check [here](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#resizing-an-in-use-persistentvolumeclaim)

Note: Note: FlexVolume resize is possible only when the underlying driver supports resize.

There is a "Note: " already.
Split out docs contributions from feature and community contributions per user feedback.
* translate reference/tools to de

* reversed plural wording

* reviewers choosen by OWNERS

Co-Authored-By: mkorbi <[email protected]>
* Add Setting up the OWNERS files section
* Update OWNERS_ALIASES patch
* Replace owners.md link with go.k8s.io/owners
* Replace github.com/kubernetes link with git.k8s.io
* Update OWNERS_ALIASES to use git.k8s.io link
* Sort patch diff in alphabetical order
* Specify clearly what teams should be added
* Remove the passive voice
* Complete alphabetical order phrase
* update image link

* Update newcommunity.css
Added a step under the sections that guide the user to install the binary using curl on the OS. This is the same format maintained by the other section on this page.
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 30, 2019
@netlify
Copy link

netlify bot commented May 30, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 1494229

https://deploy-preview-14644--kubernetes-io-master-staging.netlify.com

@PatrickLang
Copy link
Contributor

/sig windows
/sig cluster-lifecycle
/milestone 1.15

@k8s-ci-robot
Copy link
Contributor

@PatrickLang: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/sig windows
/sig cluster-lifecycle
/milestone 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels May 30, 2019
@neolit123
Copy link
Member

/hold
hi, grcusanz thanks for the PR.
please change the file location to be under:
https://kubernetes.io/docs/setup/windows/

thanks.

/sig cluster-lifecycle
xref kubernetes/kubeadm#1393

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2019
@michmike
Copy link
Contributor

@grcusanz thanks for starting this
@neolit123 , the right place for this doc is under the kubeadm section of the docs since that's where we expect users to look for it. we can link to the doc from the \setup\windows section, but this doc should live with kubeadm. my 2 cents

@neolit123
Copy link
Member

given the new docs will include mostly Windows PowerShell instructions, i'm inclined to recommend https://kubernetes.io/docs/setup/windows/ as the location and we can possibly link from the official kubeadm pages if the feature graduates to alpha.

@jimangel jimangel added this to the 1.15 milestone May 30, 2019
@PatrickLang
Copy link
Contributor

@grcusanz - can you also retarget this to dev-1.15 not master?

@cody-clark
Copy link
Contributor

Seconding @PatrickLang. Please point this to the release branch (dev-1.15).

And please sign the CLA.

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

@k8s-ci-robot k8s-ci-robot requested a review from makoscafee June 4, 2019 03:43
@grcusanz grcusanz changed the base branch from master to dev-1.15 June 6, 2019 19:31
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 6, 2019
@k8s-ci-robot
Copy link
Contributor

@grcusanz: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@makoscafee
Copy link
Contributor

Hi, @grcusanz you need help for anything to help speed up this work? We are looking to have all PR for release 1.15 merged by June 10th. Let me know if there is anything docs team can assist on this.

@neolit123
Copy link
Member

neolit123 commented Jun 10, 2019

@makoscafee as per the recent discussion on slack
this PR is moved to after v1.15, so the milestone can be removed:
https://kubernetes.slack.com/archives/C13J86Z63/p1560196459047800

@jimangel
Copy link
Member

jimangel commented Jun 11, 2019

m2 [4 hours ago]
we won't finish it for 1.15. we can push to after 1.15. thanks @claurence

/close

@jimangel jimangel closed this Jun 11, 2019
@makoscafee
Copy link
Contributor

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the 1.15 milestone Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.