Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize case: Github -> GitHub #13828

Merged
merged 1 commit into from
Apr 25, 2019

Conversation

dpb587-pivotal
Copy link
Contributor

As a brand reference, G/H should both be capitalized.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 15, 2019
@netlify
Copy link

netlify bot commented Apr 15, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 34911ec

https://deploy-preview-13828--kubernetes-io-master-staging.netlify.com

@glo-pena
Copy link
Contributor

Everything pretty straight forward and correct.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
Copy link
Member

@rlenferink rlenferink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, looks good!

/lgtm

@rlenferink
Copy link
Member

/assign @Bradamant3
as PR wrangler

Copy link
Contributor

@glo-pena glo-pena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything pretty straight forward and correct.
/lgtm

@DanyC97
Copy link
Contributor

DanyC97 commented Apr 16, 2019

@dpb587-pivotal in general we would prefer to have a PR per language since we have different teams who can review the content.

Also a smaller PR is easier to review and than a big PR like this. Not to mention that in order to merge this PR you will need to wait for every language/localization team to chime in (looking at the comments i wouldn't know on which team the people who responded are part of).

Personally i would split this PR.

@rlenferink
Copy link
Member

@dpb587-pivotal in general we would prefer to have a PR per language since we have different teams who can review the content.

Also a smaller PR is easier to review and than a big PR like this. Not to mention that in order to merge this PR you will need to wait for every language/localization team to chime in (looking at the comments i wouldn't know on which team the people who responded are part of).

Personally i would split this PR.

Hi @DanyC97 in general, I completely agree with you, e.g. having the case were multiple languages are changed. In this case only a single word is changed Github => GitHub. This is quite easy to check and therefore someone from the root-owners should be enough.

@electrocucaracha
Copy link
Contributor

I found a hit for Github in content/es//community/_index.html, can you take a look?

grep -r "Github" content/es/                                                                                                                                                                                                                                                             14:56:40
content/es//community/_index.html:                <a href="https://github.com/kubernetes/kubernetes"> Proyecto en Github </a>

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@dpb587-pivotal
Copy link
Contributor Author

@electrocucaracha can you verify the checkout you were looking at? I believe that line was already changed here, and I don't see other references in that file.

@electrocucaracha
Copy link
Contributor

@electrocucaracha can you verify the checkout you were looking at? I believe that line was already changed here, and I don't see other references in that file.

It's weird, I'm sure that I cloned and verified that on your branch... But it's true the line has the proper case(https://github.com/dpb587-pivotal/website/blob/patch-2/content/es/community/_index.html#L49)

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@DanyC97
Copy link
Contributor

DanyC97 commented Apr 18, 2019

@dpb587-pivotal in general we would prefer to have a PR per language since we have different teams who can review the content.
Also a smaller PR is easier to review and than a big PR like this. Not to mention that in order to merge this PR you will need to wait for every language/localization team to chime in (looking at the comments i wouldn't know on which team the people who responded are part of).
Personally i would split this PR.

Hi @DanyC97 in general, I completely agree with you, e.g. having the case were multiple languages are changed. In this case only a single word is changed Github => GitHub. This is quite easy to check and therefore someone from the root-owners should be enough.

i understand @rlenferink and happy with letting this PR in however we all need to be careful and not abuse / ask for a waiver just because is a simple/ minor/ typo change. The rational is that new contributors will find this PRs and they will follow on the basis that if their PR was merged, mine should be accepted too.

/lgtm

@rlenferink
Copy link
Member

rlenferink commented Apr 18, 2019

@DanyC97 That's definitely true as well! However, the PR already exists now, so for the next time indeed ;)

/lgtm

@rlenferink rlenferink added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dpb587-pivotal
Copy link
Contributor Author

Thanks for the assist, @rlenferink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language language/it Issues or PRs related to Italian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants