-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize case: Github -> GitHub #13828
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 34911ec https://deploy-preview-13828--kubernetes-io-master-staging.netlify.com |
Everything pretty straight forward and correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said, looks good!
/lgtm
/assign @Bradamant3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything pretty straight forward and correct.
/lgtm
@dpb587-pivotal in general we would prefer to have a PR per language since we have different teams who can review the content. Also a smaller PR is easier to review and than a big PR like this. Not to mention that in order to merge this PR you will need to wait for every language/localization team to chime in (looking at the comments i wouldn't know on which team the people who responded are part of). Personally i would split this PR. |
Hi @DanyC97 in general, I completely agree with you, e.g. having the case were multiple languages are changed. In this case only a single word is changed |
I found a hit for
/lgtm cancel |
@electrocucaracha can you verify the checkout you were looking at? I believe that line was already changed here, and I don't see other references in that file. |
It's weird, I'm sure that I cloned and verified that on your branch... But it's true the line has the proper case(https://github.com/dpb587-pivotal/website/blob/patch-2/content/es/community/_index.html#L49) /lgtm |
i understand @rlenferink and happy with letting this PR in however we all need to be careful and not abuse / ask for a waiver just because is a simple/ minor/ typo change. The rational is that new contributors will find this PRs and they will follow on the basis that if their PR was merged, mine should be accepted too. /lgtm |
@DanyC97 That's definitely true as well! However, the PR already exists now, so for the next time indeed ;) /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the assist, @rlenferink. |
As a brand reference, G/H should both be capitalized.