Move Using Secrets to h2. for top of page linking #14041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems like one of the key sections of the page users are likely to want to come directly to and matches the setup of some existing pages such as https://kubernetes.io/docs/concepts/workloads/controllers/jobs-run-to-completion/#advanced-usage
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 7588f71 https://deploy-preview-14041--kubernetes-io-master-staging.netlify.com |
|
/lgtm /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaredbhatti The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across #4491 however until that's actioned the
Using Secretssection is buried due to being H3 and therefore not getting top of page prominent linking. Also decreases the subheading of the subsections underUsing Secretsfrom h4 to h3This seems like one of the key sections of the page users are likely to want to come directly to and matches the setup of some existing pages such as https://kubernetes.io/docs/concepts/workloads/controllers/jobs-run-to-completion/#advanced-usage
Edited To Add: I did consider changing the section title to
Using Secrets in Podsto be more explicit, but thought the trade-off with breaking existing anchor links to the section wasn't worth it.