New Community page, as designed by @alexcontini

[cjyabraham]

This new Community page was designed over the last few months by @alexcontini. I helped implement the Upcoming Events part of it.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[netlify]

Deploy preview for kubernetes-io-master-staging ready!

Built with commit bb1fa69

https://deploy-preview-13046--kubernetes-io-master-staging.netlify.com

[cjyabraham]

CLA now signed.
/assign @jaredbhatti

[jaredbhatti]

Thanks, I was pinged by acontini to hold off on approval until he pings me with a few updates.

[rlenferink]

Suggested change

	width: 100%;

Maybe it will be good to add a width of 100% to the .banner1 as well. Otherwise the image can't be full width.

[rlenferink]

What is the status on this? As I really like the newly designed community page :D

[alexcontini]

@parispittman @castrojo this is the PR for the new community page (test page here - https://deploy-preview-13046--kubernetes-io-master-staging.netlify.com/community/)

We are still waiting on some things before merging right? just wanted to double check!

[mdlinville]

/hold

(until the waiting-for-things are done)

[alexcontini]

@parispittman @castrojo here is the updated preview page with Paris' image and text updates - https://deploy-preview-13046--kubernetes-io-master-staging.netlify.com/community/

let me know if all looks good when you have a chance!

[parispittman]

some folks are reporting that the image fencing with the descriptions of our comms channels are in and out of the box with resizing of web browser.

also - the code of conduct, videos, etc toolbar is not working for some folks

thank you for your help with everything!!

[jonasrosland]

Same comment as @parispittman above, the scaling is a little off in those boxes one larger screens.

For the events, can we organize the events so that it's spread out across multiple lines instead of being just one line?
Going from this:

to

Event
Date
Location

After clicking the links in the toolbar, the drop-down menu obscures the titles:

[jonasrosland]

Found two small things that hopefully can be looked at.

[jonasrosland]

This should be kubectl get pods, right?
And I think we can remove   on the last line.

[jonasrosland]

Should be YouTube, and I think we can remove the   here too.

[alexcontini]

@jonasrosland @parispittman @mrbobbytables

I have made the fixes, when you have a chance, will you please take a look at https://deploy-preview-13046--kubernetes-io-master-staging.netlify.com/community/ and let me know if all looks good now.

The only one I was unsure about it the anchor links, they were working for me in both browsers so it was hard to figure out the issue, i did change something though so let me know if not fixed now. I also moved up the anchors so they shouldn't cut off the titles anymore hopefully

[mrbobbytables]

@alexcontini That fixed it for me :)
Thank you!

[jonasrosland]

Hi @alexcontini!

Thank you for working on this, it's looking really good :)

The site still says kubectrl get pods, it should be kubectl get pods.

The squares at the bottom aren't uniform, but the text alignment looks much better :)

Large screen:

Smaller screen:

I see the events are now split up into

Event
Location - Time

It looks a little strange still:

Could it be set up on 3 lines without any -? Like this:

Event
Location
Time

The anchor links looks better but still seems to require a little trimming:
CoC:

Videos:

Discussions now have a big block above it compared to before:

Same with events:

This is in Safari on latest Mac OSX, and the same happens in Chrome.

[mrbobbytables]

@jonasrosland The event data is sourced from an external calendar. It'd be fixing it there.
The anchor links look okay for me on chrome (Version 73.0.3683.103 (Official Build) (64-bit)) on OSX.

The boxes do shift size when resizing.

[mrbobbytables]

Okay, was able to replicate the anchor thing, but it was only when I had the page sized a bit bigger than above where it flips to mobile menu form.

[alexcontini]

@mrbobbytables @jonasrosland
I have made some fixes: https://deploy-preview-13046--kubernetes-io-master-staging.netlify.com/community/

1. The resource box alignment - I added a min-height, but it's been tricky to make it match perfectly at every width because the text is such different lengths in each box (that is why I set the height before, but then it was getting cut off) - let me know if this looks any better to you!

2. The anchor links - I added more spacing above the titles at the width where the menu becomes the mobile menu, so the issue before with the words getting cut off shouldn't happen anymore, let me know otherwise.

3. The event section text - @mrbobbytables mentioned this above but it's all feeding through a google calendar so I can't edit the way the text looks. I will ask someone on the team if they can change that though

Let me know if this looks good to you when you have a chance, and thank you for all the feedback!

[jonasrosland]

Looks really good @alexcontini ! Thanks for those fixes, seems like it works great now.
The calendar piece is more of a nice-to-have than anything else, so I think that could be worked on afterwards.

Looks like you might need to squash a few commits to get rid of the nags from the bot though :)

/lgtm

[zacharysarah]

@cjyabraham @alexcontini This looks so good! ✨

Some feedback:

1. There's a merge conflict to resolve.
2. Please squash your commits by rebasing.
3. This PR is old enough that the preview is still displaying 1.13 as the latest version. That's not a problem, since there's no merge conflict with the version selector. Rebasing should pull in the latest changes and update the preview.

[cjyabraham]

I have squashed and rebased the commits. The merge conflict brought in the "Talk to Us" section that you can see on the live site. It is now poorly formatted and also seems to have hidden our embedded twitter widget. See preview.

@alexcontini can you fix this please?

[alexcontini]

@zacharysarah thank you! above issue is fixed (https://deploy-preview-13046--kubernetes-io-master-staging.netlify.com/community/) and all else should be ready now, are you able to merge when you have a chance?

[parispittman]

Thanks @alexcontini and @cjyabraham for all of your hard work :)

[zacharysarah]

/approve

[zacharysarah]

/lgtm

@alexcontini /hold cancel when ready to merge.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zacharysarah]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alexcontini]

/hold cancel