Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for i18n/ko.toml #13951

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

seokho-son
Copy link
Member

This PR updates i18n/ko.toml
to translate i18n/en.toml according to the recent update from #13832.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2019
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 22, 2019
@seokho-son
Copy link
Member Author

Since this PR includes Korean contents, I expect review comments from Korean localization team.
@gochist. Could you help?

@netlify
Copy link

netlify bot commented Apr 22, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit b17e796

https://deploy-preview-13951--kubernetes-io-master-staging.netlify.com

@seokho-son
Copy link
Member Author

@gochist
Copy link
Member

gochist commented Apr 22, 2019

@seokho-son Thank you! As a native Korean speaker, it looks good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2019
@seokho-son
Copy link
Member Author

@zacharysarah could you take a look on this PR? It is about i18n/ko.toml translation. Thank you.

@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0bad398 into kubernetes:master Apr 25, 2019
@zacharysarah
Copy link
Contributor

There needs to be a way for localization teams to approve changes in this directory. The easiest way may be to add an OWNERS with approval permissions for each sig-docs-**-owners team.

@seokho-son
Copy link
Member Author

There needs to be a way for localization teams to approve changes in this directory. The easiest way may be to add an OWNERS with approval permissions for each sig-docs-**-owners team.

@zacharysarah, I agree with you. It would improve the efficiency for i18n work. (cc: @gochist)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants