-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Setting up the OWNERS files section #13912
Add Setting up the OWNERS files section #13912
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 01bf302 https://deploy-preview-13912--kubernetes-io-master-staging.netlify.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good. Could you change the @sieben github handle?
770d7a0
to
d7cea87
Compare
|
||
More information about the `OWNERS` file can be found at [community/contributors/guide/owners.md](https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md). | ||
|
||
The [Spanish OWNERS file](https://github.com/kubernetes/website/blob/master/content/es/OWNERS), with language code `es`, looks like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we use https://git.k8s.io/website/content/es/OWNERS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Is the usage of git.k8s.io
and go.k8s.io
referenced in any style guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the usage of git.k8s.io and go.k8s.io referenced in any style guide?
https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md#links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bdebf2e
to
a559ea3
Compare
Holding so I can review it more closely |
a559ea3
to
d0b2039
Compare
- language/es | ||
``` | ||
|
||
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to specify clearly what teams should be added (here sig-docs-**-owners
and sig-docs-**-reviews
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like this?
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization. | |
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams (`sig-docs-**-owners and `sig-docs-**-reviews`) for the localization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a clarification in abe9b70
d0b2039
to
abe9b70
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@raelga Looks good! ✨ Some minor nits, then LGTM
|
||
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization, `sig-docs-**-owners` and `sig-docs-**-reviews`. | ||
|
||
For each team, add the list of GitHub users requested in [Add your localization team in GitHub](#add-your-localization-team-in-github), in alphabetical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- language/es | ||
``` | ||
|
||
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization, `sig-docs-**-owners` and `sig-docs-**-reviews`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eliminate passive voice:
Once you create the language-specific `OWNERS` file...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel |
* Add Setting up the OWNERS files section * Update OWNERS_ALIASES patch * Replace owners.md link with go.k8s.io/owners * Replace github.com/kubernetes link with git.k8s.io * Update OWNERS_ALIASES to use git.k8s.io link * Sort patch diff in alphabetical order * Specify clearly what teams should be added * Remove the passive voice * Complete alphabetical order phrase
abe9b70
to
01bf302
Compare
Thanks for updating! /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Once the localization teams are created, there are some tasks related to the
OWNERS
files that need to be done.This PR adds those tasks to the content/en/docs/contribute/localization.md page.
/cc @remyleone @zacharysarah @rlenferink