Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Setting up the OWNERS files section #13912

Merged

Conversation

raelga
Copy link
Member

@raelga raelga commented Apr 20, 2019

Once the localization teams are created, there are some tasks related to the OWNERS files that need to be done.

This PR adds those tasks to the content/en/docs/contribute/localization.md page.

/cc @remyleone @zacharysarah @rlenferink

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 20, 2019
@netlify
Copy link

netlify bot commented Apr 20, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 01bf302

https://deploy-preview-13912--kubernetes-io-master-staging.netlify.com

Copy link
Contributor

@remyleone remyleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good. Could you change the @sieben github handle?

@raelga raelga force-pushed the add-OWNERS-files-localization-setup branch from 770d7a0 to d7cea87 Compare April 20, 2019 09:23

More information about the `OWNERS` file can be found at [community/contributors/guide/owners.md](https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md).

The [Spanish OWNERS file](https://github.com/kubernetes/website/blob/master/content/es/OWNERS), with language code `es`, looks like:
Copy link
Member

@nikhita nikhita Apr 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the usage of git.k8s.io and go.k8s.io referenced in any style guide?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the usage of git.k8s.io and go.k8s.io referenced in any style guide?

https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md#links

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raelga raelga force-pushed the add-OWNERS-files-localization-setup branch 2 times, most recently from bdebf2e to a559ea3 Compare April 20, 2019 09:47
@zacharysarah
Copy link
Contributor

Holding so I can review it more closely
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2019
@raelga raelga force-pushed the add-OWNERS-files-localization-setup branch from a559ea3 to d0b2039 Compare April 21, 2019 13:15
- language/es
```

Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to specify clearly what teams should be added (here sig-docs-**-owners and sig-docs-**-reviews).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this?

Suggested change
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization.
Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams (`sig-docs-**-owners and `sig-docs-**-reviews`) for the localization.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a clarification in abe9b70

@raelga raelga force-pushed the add-OWNERS-files-localization-setup branch from d0b2039 to abe9b70 Compare April 23, 2019 18:49
@rlenferink
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raelga Looks good! ✨ Some minor nits, then LGTM


Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization, `sig-docs-**-owners` and `sig-docs-**-reviews`.

For each team, add the list of GitHub users requested in [Add your localization team in GitHub](#add-your-localization-team-in-github), in alphabetical.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in alphabetical order.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- language/es
```

Once the language-specific `OWNERS` file is created, update the [root `OWNERS_ALIASES`](https://git.k8s.io/website/OWNERS_ALIASES) file with the new Kubernetes teams for the localization, `sig-docs-**-owners` and `sig-docs-**-reviews`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eliminate passive voice:

Once you create the language-specific `OWNERS` file...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zacharysarah
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019
* Add Setting up the OWNERS files section
* Update OWNERS_ALIASES patch
* Replace owners.md link with go.k8s.io/owners
* Replace github.com/kubernetes link with git.k8s.io
* Update OWNERS_ALIASES to use git.k8s.io link
* Sort patch diff in alphabetical order
* Specify clearly what teams should be added
* Remove the passive voice
* Complete alphabetical order phrase
@raelga raelga force-pushed the add-OWNERS-files-localization-setup branch from abe9b70 to 01bf302 Compare April 27, 2019 18:34
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2019
@raelga raelga requested a review from zacharysarah April 27, 2019 18:37
@rlenferink
Copy link
Member

Thanks for updating!

/lgtm
/assign @zacharysarah
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2019
@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit e91df53 into kubernetes:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants