Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code (32.0) #4550

Closed
reckart opened this issue Feb 24, 2024 · 0 comments
Closed

Clean up code (32.0) #4550

reckart opened this issue Feb 24, 2024 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Milestone
32.0

Comments

@reckart
Copy link
Member

reckart commented Feb 24, 2024

Describe the refactoring action
Clean up code here and there while reviewing.

Expected benefit
Cleaner code.
@reckart reckart added this to the 32.0 milestone Feb 24, 2024
@reckart reckart self-assigned this Feb 24, 2024
reckart added a commit that referenced this issue Feb 24, 2024
@reckart
#4550 - Clean up code
4291e36 
- Clean up code in the document export module
reckart added a commit that referenced this issue Feb 24, 2024
@reckart
#4550 - Clean up code
aabad71 
- Remove unused and deprecated old brat comment popup code
reckart added a commit that referenced this issue Feb 24, 2024
@reckart
#4550 - Clean up code
0f87d1b 
- Remove unused and deprecated old brat comment popup code
reckart added a commit that referenced this issue Feb 24, 2024
@reckart
#4550 - Clean up code
09a133d 
- Remove unused and deprecated old brat comment popup code
reckart added a commit that referenced this issue Feb 24, 2024
@reckart
Merge pull request #4551 from inception-project/4550-Clean-up-code
0f3a123 
#4550 - Clean up code
reckart added a commit that referenced this issue Feb 24, 2024
@reckart
Merge branch 'main' into feature/4554-Allow-displaying-comments-from-…
f5db467 
…annotators-on-hover-when-curating-using-curation-sidebar-on-the-annotation-page

* main:
  #4552 - No details shown when hovering over annotations in lower part of the curation page
  #4550 - Clean up code
  #4550 - Clean up code
reckart added a commit that referenced this issue Feb 25, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
7b03898 
* main: (95 commits)
  #4556 - Unable to access PMC BioC service
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  #4552 - No details shown when hovering over annotations in lower part of the curation page
  #4550 - Clean up code
  #4550 - Clean up code
  #4547 - Cannot create long-distance relation in PDF editor
  #4545 - Upgrade dependencies
  #4545 - Upgrade dependencies
  #4543 - UI for creating new concept or properties has broken layout
  #4541 - Upgrade dependencies
  #4538 - Lazy details and selecting annotations my break after opening a read-only document and not performing actions for a short time
  #4537 - Ability to group annotations by layer
  #4533 - BioC exported from INCEpTION cannot be imported again due to missing mandatory metadata
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.1
  #4530 - Keyboard shortcuts for feature values may not work in certain editors
  #4528 - Display key bindings in radio group string feature editor
  #4525 - Support recommendations for non-string primitive features
  #4523 - Factor endpoint-specific FTS code out into adapter classes
  #4523 - Factor endpoint-specific FTS code out into adapter classes
  ...

% Conflicts:
%	inception/inception-dependencies/pom.xml
%	inception/inception-imls-weblicht/pom.xml
%	inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/KnowledgeBaseServiceImpl.java
%	inception/inception-project-export/src/test/resources/log4j2-test.xml
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/SelectionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-ui-curation/pom.xml
%	inception/inception-ui-dashboard-activity/pom.xml
%	inception/inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/initializers/NamedEntityIdentifierFeatureInitializer.java
%	inception/inception-ui-scheduling/pom.xml
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	pom.xml
reckart added a commit that referenced this issue Feb 25, 2024
@reckart
#4550 - Clean up code
a52f463 
- Modernizing and cleaning up code
reckart added a commit that referenced this issue Feb 25, 2024
@reckart
Merge pull request #4559 from inception-project/refactoring/4550-Clea…
0fa3d44 
…n-up-code

#4550 - Clean up code
reckart added a commit that referenced this issue Feb 26, 2024
@reckart
Merge branch 'main' into refactoring/4558-Better-verification-for-fea…
4bc22f3 
…ture-names

* main:
  #4560 - Describe how to use ELK to process Snomed before import
  #4513 - Support full text search in knowledge bases running on Blazegraph
  #4550 - Clean up code
@reckart reckart changed the title Clean up code Clean up code (32.0) Mar 3, 2024
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
#4550 - Clean up code
74b0d82 
- Use var
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
Merge pull request #4620 from inception-project/refactoring/4550-Clea…
d0ee4f1 
…n-up-code

#4550 - Clean up code
reckart added a commit that referenced this issue Mar 12, 2024
@reckart
Merge branch 'main' into feature/1321-Importing-.ann-files-from-BRAT
5c522da 
* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.3
  #4622 - No helpful error message when recommender is not called due to feature being disabled
  #4550 - Clean up code
reckart added a commit that referenced this issue Mar 13, 2024
@reckart
#4550 - Clean up code
d59186a 
- Formatting
- Fix error in documentation
reckart added a commit that referenced this issue Mar 15, 2024
@reckart
Merge pull request #4627 from inception-project/refactoring/4550-Clea…
0f15022 
…n-up-code

#4550 - Clean up code
reckart added a commit that referenced this issue Mar 16, 2024
@reckart
#4550 - Clean up code
6d20a5f 
- Using var
- Added ability to set content type on InputStreamResourceStream
reckart added a commit that referenced this issue Mar 16, 2024
@reckart
Merge pull request #4633 from inception-project/refactoring/4450-Clea…
1dfbab2 
…n-up-code

#4550 - Clean up code
reckart added a commit that referenced this issue Mar 17, 2024
@reckart
Merge branch 'main' into feature/1321-Importing-.ann-files-from-BRAT
ef44fa9 
* main:
  #4638 - Ability to filter annotation sidebar by covered text
  #4636 - Ability to collapse groups in annotation sidebar
  #4634 - Pull document file storage code out of document service into a new service
  #4550 - Clean up code
  #4625 - Azure AI Open AI recommender
  #4628 - Better results when using unlabelled annotations for few-shot learning
  #4550 - Clean up code
  #4625 - Azure AI Open AI recommender
reckart added a commit that referenced this issue Mar 17, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
fea0068 
* main:
  #1321 - Importing .ann files from BRAT
  #4614 - Display suggestions from Named Entity Linker immediately
  #4638 - Ability to filter annotation sidebar by covered text
  #4636 - Ability to collapse groups in annotation sidebar
  #4634 - Pull document file storage code out of document service into a new service
  #4550 - Clean up code
  #4625 - Azure AI Open AI recommender
  #4628 - Better results when using unlabelled annotations for few-shot learning
  #4550 - Clean up code
  #4625 - Azure AI Open AI recommender
  #1321 - Importing .ann files from BRAT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.3
  #1321 - Importing .ann files from BRAT
  #4622 - No helpful error message when recommender is not called due to feature being disabled
  No issue: Better logging
  #4550 - Clean up code
@reckart reckart closed this as completed Mar 22, 2024
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
32.0
Development

No branches or pull requests
1 participant
@reckart