Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor endpoint-specific FTS code out into adapter classes #4523

Closed
reckart opened this issue Feb 17, 2024 · 0 comments
Closed

Factor endpoint-specific FTS code out into adapter classes #4523

reckart opened this issue Feb 17, 2024 · 0 comments
Assignees
@reckart
Labels
Module: Knowledge Base ⚙️ Refactoring
Milestone
32.0

Comments

@reckart
Copy link
Member

reckart commented Feb 17, 2024

Describe the refactoring action
The SparqlQueryBuilder has different methods for calling different FTS mechanisms. This should be factored out into classes.

Expected benefit
Better maintainability.
@reckart reckart added this to the 31.1 milestone Feb 17, 2024
@reckart reckart self-assigned this Feb 17, 2024
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
f88888e 
- Started by factoring out the "withLabelMatchingExactlyAnyOf" calls
@reckart reckart modified the milestones: 31.1, 32.0 Feb 17, 2024
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
82afe21 
- Factoring out the "withLabelContainingAnyOf" calls
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
bf105ac 
- Factor out the remaining calls
- Start trying to separate adapter classes from query builder
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
b9ed9c7 
- Extract FTS adapter classes from query builder
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
20c9293 
- Extract FTS adapter classes from query builder
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
014e7dd 
- Extract FTS adapter classes from query builder
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
0ad9b32 
- Extract FTS adapter classes from query builder
reckart added a commit that referenced this issue Feb 17, 2024
@reckart
#4523 - Factor endpoint-specific FTS code out into adapter classes
80fc775 
- Further disentangle test code
reckart added a commit that referenced this issue Feb 18, 2024
@reckart
Merge pull request #4524 from inception-project/refactoring/4523-Fact…
7916bd4 
…or-endpoint-specific-FTS-code-out-into-adapter-classes

#4523 - Factor endpoint-specific FTS code out into adapter classes
@reckart reckart closed this as completed Feb 18, 2024
reckart added a commit that referenced this issue Feb 25, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
7b03898 
* main: (95 commits)
  #4556 - Unable to access PMC BioC service
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  #4552 - No details shown when hovering over annotations in lower part of the curation page
  #4550 - Clean up code
  #4550 - Clean up code
  #4547 - Cannot create long-distance relation in PDF editor
  #4545 - Upgrade dependencies
  #4545 - Upgrade dependencies
  #4543 - UI for creating new concept or properties has broken layout
  #4541 - Upgrade dependencies
  #4538 - Lazy details and selecting annotations my break after opening a read-only document and not performing actions for a short time
  #4537 - Ability to group annotations by layer
  #4533 - BioC exported from INCEpTION cannot be imported again due to missing mandatory metadata
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.1
  #4530 - Keyboard shortcuts for feature values may not work in certain editors
  #4528 - Display key bindings in radio group string feature editor
  #4525 - Support recommendations for non-string primitive features
  #4523 - Factor endpoint-specific FTS code out into adapter classes
  #4523 - Factor endpoint-specific FTS code out into adapter classes
  ...

% Conflicts:
%	inception/inception-dependencies/pom.xml
%	inception/inception-imls-weblicht/pom.xml
%	inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/KnowledgeBaseServiceImpl.java
%	inception/inception-project-export/src/test/resources/log4j2-test.xml
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/SelectionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-ui-curation/pom.xml
%	inception/inception-ui-dashboard-activity/pom.xml
%	inception/inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/initializers/NamedEntityIdentifierFeatureInitializer.java
%	inception/inception-ui-scheduling/pom.xml
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
Module: Knowledge Base ⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
32.0
Development

No branches or pull requests
1 participant
@reckart