Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support recommendations for boolean features #4525

Closed
4 tasks done
reckart opened this issue Feb 18, 2024 · 0 comments
Closed
4 tasks done

Support recommendations for boolean features #4525

reckart opened this issue Feb 18, 2024 · 0 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request Module: Recommender
Milestone
32.0

Comments

@reckart
Copy link
Member

reckart commented Feb 18, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
There are currently no recommenders that support non-string primitive features. And when trying to use an external recommender for such features, some functionalities like active learning break.

Describe the solution you'd like
It should be possible to have recommenders for non-string primitive features (i.e. boolean, integer, float).

To do

  • boolean (string matcher)
  • boolean (OpenNLP multi-token sequence classifier)
  • boolean (OpenNLP doccat recommender)
  • boolean (active learning)
@reckart reckart added this to the 32.0 milestone Feb 18, 2024
@reckart reckart self-assigned this Feb 18, 2024
reckart added a commit that referenced this issue Feb 18, 2024
@reckart
#4525 - Support recommendations for non-string primitive features
1c7c1a0 
- Boolean features now seem to work in String Matching recommender and Active Learning Sidebar
reckart added a commit that referenced this issue Feb 18, 2024
@reckart
Merge pull request #4526 from inception-project/feature/4525-Support-…
21a8bc4 
…recommendations-for-non-string-primitive-features

#4525 - Support recommendations for non-string primitive features
reckart added a commit that referenced this issue Feb 25, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
7b03898 
* main: (95 commits)
  #4556 - Unable to access PMC BioC service
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  #4552 - No details shown when hovering over annotations in lower part of the curation page
  #4550 - Clean up code
  #4550 - Clean up code
  #4547 - Cannot create long-distance relation in PDF editor
  #4545 - Upgrade dependencies
  #4545 - Upgrade dependencies
  #4543 - UI for creating new concept or properties has broken layout
  #4541 - Upgrade dependencies
  #4538 - Lazy details and selecting annotations my break after opening a read-only document and not performing actions for a short time
  #4537 - Ability to group annotations by layer
  #4533 - BioC exported from INCEpTION cannot be imported again due to missing mandatory metadata
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-31.1
  #4530 - Keyboard shortcuts for feature values may not work in certain editors
  #4528 - Display key bindings in radio group string feature editor
  #4525 - Support recommendations for non-string primitive features
  #4523 - Factor endpoint-specific FTS code out into adapter classes
  #4523 - Factor endpoint-specific FTS code out into adapter classes
  ...

% Conflicts:
%	inception/inception-dependencies/pom.xml
%	inception/inception-imls-weblicht/pom.xml
%	inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/KnowledgeBaseServiceImpl.java
%	inception/inception-project-export/src/test/resources/log4j2-test.xml
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/SelectionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-ui-curation/pom.xml
%	inception/inception-ui-dashboard-activity/pom.xml
%	inception/inception-ui-kb/src/main/java/de/tudarmstadt/ukp/inception/ui/kb/initializers/NamedEntityIdentifierFeatureInitializer.java
%	inception/inception-ui-scheduling/pom.xml
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	pom.xml
@reckart reckart mentioned this issue Apr 3, 2024
Closed
reckart added a commit that referenced this issue Apr 3, 2024
@reckart
#4525 - Support recommendations for non-string primitive features
7a4ec08 
- Support boolean feature values in OpenNLP sequence classifier
reckart added a commit that referenced this issue Apr 4, 2024
@reckart
Merge pull request #4682 from inception-project/feature/4525-Support-…
47a17b6 
…recommendations-for-non-string-primitive-features

#4525 - Support recommendations for non-string primitive features
@reckart reckart changed the title Support recommendations for non-string primitive features Support recommendations for boolean features Apr 4, 2024
reckart added a commit that referenced this issue Apr 4, 2024
@reckart
#4525 - Support recommendations for boolean features
c272986 
- Add support for boolean features to the doccat recommender
- Fix issue editing the traits of the doccat recommender
reckart added a commit that referenced this issue Apr 4, 2024
@reckart
Merge pull request #4687 from inception-project/feature/4525-Support-…
6b63d6b 
…recommendations-for-boolean-features

#4525 - Support recommendations for boolean features
@reckart reckart closed this as completed Apr 4, 2024
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
Kanban
Archived in project
Milestone
32.0
Development

No branches or pull requests
1 participant
@reckart