#4525 - Support recommendations for non-string primitive features

- Support boolean feature values in OpenNLP sequence classifier
inception-project · Apr 3, 2024 · 7a4ec08 · 7a4ec08
1 parent dda5615
commit 7a4ec08
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/...a/de/tudarmstadt/ukp/inception/recommendation/imls/opennlp/ner/OpenNlpNerRecommender.java b/...a/de/tudarmstadt/ukp/inception/recommendation/imls/opennlp/ner/OpenNlpNerRecommender.java
@@ -187,7 +187,7 @@ public Range predict(PredictionContext aContext, CAS aCas, int aBegin, int aEnd)
                 var end = tokens.get(prediction.getEnd() - 1).getEnd();
                 var annotation = aCas.createAnnotation(predictedType, begin, end);
 
-                annotation.setStringValue(predictedFeature, label);
+                annotation.setFeatureValueFromString(predictedFeature, label);
                 if (scoreFeature != null) {
                     annotation.setDoubleValue(scoreFeature, prediction.getProb());
                 }

diff --git a/...darmstadt/ukp/inception/recommendation/imls/opennlp/ner/OpenNlpNerRecommenderFactory.java b/...darmstadt/ukp/inception/recommendation/imls/opennlp/ner/OpenNlpNerRecommenderFactory.java
@@ -70,7 +70,8 @@ public boolean accepts(AnnotationLayer aLayer, AnnotationFeature aFeature)
 
         return (asList(SINGLE_TOKEN, TOKENS, SENTENCES).contains(aLayer.getAnchoringMode()))
                 && SpanLayerSupport.TYPE.equals(aLayer.getType())
-                && (CAS.TYPE_NAME_STRING.equals(aFeature.getType()) || aFeature.isVirtualFeature());
+                && (asList(CAS.TYPE_NAME_STRING, CAS.TYPE_NAME_BOOLEAN).contains(aFeature.getType())
+                        || aFeature.isVirtualFeature());
     }
 
     @Override

diff --git a/.../tudarmstadt/ukp/inception/recommendation/imls/opennlp/ner/OpenNlpNerRecommenderTest.java b/.../tudarmstadt/ukp/inception/recommendation/imls/opennlp/ner/OpenNlpNerRecommenderTest.java
@@ -215,10 +215,10 @@ public void thatEvaluationWorks() throws Exception
         var precision = result.computePrecisionScore();
         var recall = result.computeRecallScore();
 
-        System.out.printf("F1-Score: %f%n", fscore);
-        System.out.printf("Accuracy: %f%n", accuracy);
-        System.out.printf("Precision: %f%n", precision);
-        System.out.printf("Recall: %f%n", recall);
+        LOG.info("F1-Score:  {}", fscore);
+        LOG.info("Accuracy:  {}", accuracy);
+        LOG.info("Precision: {}", precision);
+        LOG.info("Recall:    {}", recall);
 
         assertThat(fscore).isBetween(0.0, 1.0);
         assertThat(precision).isBetween(0.0, 1.0);
@@ -243,10 +243,10 @@ public void thatEvaluationWorksNoLabels() throws Exception
         var precision = result.computePrecisionScore();
         var recall = result.computeRecallScore();
 
-        System.out.printf("F1-Score: %f%n", fscore);
-        System.out.printf("Accuracy: %f%n", accuracy);
-        System.out.printf("Precision: %f%n", precision);
-        System.out.printf("Recall: %f%n", recall);
+        LOG.info("F1-Score:  {}", fscore);
+        LOG.info("Accuracy:  {}", accuracy);
+        LOG.info("Precision: {}", precision);
+        LOG.info("Recall:    {}", recall);
 
         assertThat(fscore).isBetween(0.0, 1.0);
         assertThat(precision).isBetween(0.0, 1.0);